From: Lee Jones <lee.jones@linaro.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag
Date: Wed, 13 Jan 2021 17:12:11 +0000 [thread overview]
Message-ID: <20210113171211.GF3975472@dell> (raw)
In-Reply-To: <87bldssrzu.fsf@intel.com>
On Wed, 13 Jan 2021, Jani Nikula wrote:
> On Wed, 13 Jan 2021, Lee Jones <lee.jones@linaro.org> wrote:
> > Clear-up any confusion surrounding the Fixes: tag with regards to the
> > need to Cc: the stable mailing list when submitting stable patch
> > candidates.
> >
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: linux-doc@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > v2:
> > - Link to the 'stable-kernel-rules' document as per Greg's request
> >
> > Documentation/process/submitting-patches.rst | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> > index 7c97ad580e7d0..7f48cccc75cdf 100644
> > --- a/Documentation/process/submitting-patches.rst
> > +++ b/Documentation/process/submitting-patches.rst
> > @@ -556,6 +556,11 @@ which stable kernel versions should receive your fix. This is the preferred
> > method for indicating a bug fixed by the patch. See :ref:`describe_changes`
> > for more details.
> >
> > +Note: Attaching a Fixes: tag does not subvert the stable kernel rules
> > +process nor the requirement to Cc: stable@vger.kernel.org on all stable
> > +patch candidates. For more information, please read
> > +:ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`
>
> Has there been a process change, or should I take it that a Fixes: tag
> without Cc: stable *may* still end up being backported to stable?
The 'process' has not changed. Cc:ing the stable mailing list has
been a requirement for years. This patch clears up the misconception
that you (and I ... and many others by all accounts) hold that the
Fixes: tag is enough.
Fixes: only works when/if Greg and/or Sasha run their magical scripts
to scan for them. By them doing so has "perpetuated a myth that this
was the proper thing to do". It's not.
Greg got fed-up of people asking that same question, so I'm fixing
that and giving him something to point to and say "RTFD".
Hope that clears things up.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-01-13 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 16:33 [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag Lee Jones
2021-01-13 16:38 ` Greg Kroah-Hartman
2021-01-13 16:48 ` Jani Nikula
2021-01-13 17:12 ` Lee Jones [this message]
2021-01-13 17:35 ` Jani Nikula
2021-01-13 20:33 ` Lee Jones
2021-01-18 20:09 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113171211.GF3975472@dell \
--to=lee.jones@linaro.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox