From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3869AC433DB for ; Wed, 13 Jan 2021 23:46:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4BF12250E for ; Wed, 13 Jan 2021 23:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729593AbhAMXpt (ORCPT ); Wed, 13 Jan 2021 18:45:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729532AbhAMXmB (ORCPT ); Wed, 13 Jan 2021 18:42:01 -0500 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F031C061389 for ; Wed, 13 Jan 2021 15:40:47 -0800 (PST) Received: by mail-qk1-x730.google.com with SMTP id 143so4697270qke.10 for ; Wed, 13 Jan 2021 15:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eWOJblEmC2Qz30+n062pHjcbFMkB3dcTw0EMbDyU9wY=; b=g7Myi4v2XKsgahixTj7abmQLC+QpYM/NxeNwy/T8Ur/tenbnt6MQs8Sid+jONGzRNm AI4vOuYLwnMplCgfxZdoOUxfSCGGPzTI0rBZZeDZLugknRZWcI1fBRE7t0Y26Bq1lhDn D2v+ZmEhMwZe5THa8LEBL/6+hwEc80GktfKyYBm9B2dFlfu8sXyyEgUNb6rVw4bNvV9F rjHEQn6/W+mNOc2uFt1hqrzZBmxkdb7iifCZ1CZKz5lTnPfzjqD/9qPOCswmP7TaTbe9 SrkZUewTrJw/en30riV5ldgu6rAHbskg6Z5JXS+Yk1vFxG1U42IhrdUMlq8PkrzzN+3a wzpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eWOJblEmC2Qz30+n062pHjcbFMkB3dcTw0EMbDyU9wY=; b=YXLuvM4nnO/Qo/siC1HzNSuruTD5Kx5j5AT1sqVz4d9Tj5HGXzHZk9vDBOckBWoC0f /FMTKrNZMNZZ65tBZXiCNoC0wMdXR/bgKFFBaOkDkGA8gZkwb2dippKFcMlDmI3l5DVF BbvJ3etYpkLd/ZevY5n6CLceTt+t1HojBB66ixqL/n9cC2BR4KZ3tOSUQqI3qgWJRZSn exj4dwvioIVrF0YEcDVyjaORQTxsowffHVJjEiUSKiMaLSXsMM65Hoo/+BwPx4DMo/t1 ICBE9vfy2VIkX5bwvl9e7L+SZI/GVE+m/18Zw43XiU5ESX2I62gzHmR78LuOA0S6a/a1 s8NQ== X-Gm-Message-State: AOAM531Ph9mYd+LDcWhhE9lQxf46HqvxDEIZ+WSXXMtcPBv4yN+zquqk JoTiYxo2oMgSvJYVLnWiGPoYog== X-Google-Smtp-Source: ABdhPJy0csB1QSw/8eYTomPSY9yssASx5+uIbw+aIaQIxvw9keP0iEvsHPmZYqbPjcaIzfDKssrusA== X-Received: by 2002:a05:620a:673:: with SMTP id a19mr4538618qkh.353.1610581246377; Wed, 13 Jan 2021 15:40:46 -0800 (PST) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id y13sm2147803qkb.17.2021.01.13.15.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 15:40:45 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kzpkq-000htB-US; Wed, 13 Jan 2021 19:40:44 -0400 Date: Wed, 13 Jan 2021 19:40:44 -0400 From: Jason Gunthorpe To: Pavel Tatashin Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , mike.kravetz@oracle.com, Steven Rostedt , Ingo Molnar , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard , Linux Doc Mailing List , Ira Weiny , linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 08/10] mm/gup: limit number of gup migration failures, honor failures Message-ID: <20210113234044.GF4605@ziepe.ca> References: <20201217185243.3288048-1-pasha.tatashin@soleen.com> <20201217185243.3288048-9-pasha.tatashin@soleen.com> <20201217205048.GL5487@ziepe.ca> <20201218141927.GM5487@ziepe.ca> <20210113195528.GD4605@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2021 at 03:05:41PM -0500, Pavel Tatashin wrote: > Makes sense, I will remove maximum retries for isolation, and retry > indefinitely, the same as it is done during memory hot-remove. So, we > will fail only when migration fails. It would be good to make this also as a stand alone pre-fix as well.. Thanks, Jason