Re: [External] Re: [PATCH v12 03/13] mm: Introduce VM_WARN_ON_PAGE macro

Muchun Song
2021-01-14T02:52:47Z

On Thu, Jan 14, 2021 at 6:31 AM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> On 1/6/21 6:19 AM, Muchun Song wrote:
> > Very similar to VM_WARN_ON_ONCE_PAGE and VM_BUG_ON_PAGE, add
> > VM_WARN_ON_PAGE macro.
> >
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> > ---
> > include/linux/mmdebug.h | 8 ++++++++
> > 1 file changed, 8 insertions(+)
>
> I was going to question the use/need for this macro in the following
> patch. Looks like Oscar has already done that, and free_bootmem_page
> will now use VM_BUG_ON_PAGE. So, this patch can be dropped.

In the previous version, Oscar suggested I use WARN_ON instead of
BUG_ON. But he realised we actually should use BUG_ON in this
version. So I will drop this in the next version. Thanks.

>
> --
> Mike Kravetz