From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E26C433E0 for ; Thu, 14 Jan 2021 12:58:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4597523A05 for ; Thu, 14 Jan 2021 12:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727017AbhANM6W (ORCPT ); Thu, 14 Jan 2021 07:58:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:33230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726259AbhANM6V (ORCPT ); Thu, 14 Jan 2021 07:58:21 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1227623A05; Thu, 14 Jan 2021 12:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610629061; bh=BUpI2I9YMH+a7xHPqtdhvLSJlin/ivqWxM8HyiZg4sg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RqD9XxyWlekyv/gLyTaL9PcpnRwyBGF2MDWXMSpSA/9GoJ/TVUGCFDzeUNEVVLJMD j/B+Q3ecGOk7Csd54uib6opA/iPDCHcYcPb8s+nOJZC4Zs4CMGwpvImj3PTog4i/NC k0CkI828OisKLYIZOdSjj6tCzemN53F03SmzBYZakH91sUHL3NiI8o/baDFsYAnKS+ DcdWTEtyN+eaWXF0OOSStNFND8LLSp2SMSuNzh5E6yLs6+DyhrYdbKA9ar3kjBVZ7N 2dXOAq/Ei+4ubSoLkXBaiZM0jmdokv5DCpqlzDWOo6xvMt1IyywrSL8RAQRNqkqUj7 wExK0MJKh9d/A== Date: Thu, 14 Jan 2021 14:57:34 +0200 From: Mike Rapoport To: Tony Luck Cc: Andrew Morton , Guenter Roeck , Mike Rapoport , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ia64: fix build failure caused by memory model changes Message-ID: <20210114125734.GI1106298@kernel.org> References: <20201218163550.8838-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201218163550.8838-1-rppt@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew, Would you like me to On Fri, Dec 18, 2020 at 06:35:50PM +0200, Mike Rapoport wrote: > From: Mike Rapoport > > The change of ia64's default memory model to SPARSEMEM causes defconfig > build to fail: > > CC kernel/async.o > In file included from include/linux/numa.h:25, > from include/linux/async.h:13, > from kernel/async.c:47: > arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined, evaluates to 0 [-Wundef] > 14 | #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) > | ^~~~~~~~~~ > In file included from include/linux/gfp.h:6, > from include/linux/xarray.h:14, > from include/linux/radix-tree.h:19, > from include/linux/idr.h:15, > from include/linux/kernfs.h:13, > from include/linux/sysfs.h:16, > from include/linux/kobject.h:20, > from include/linux/energy_model.h:7, > from include/linux/device.h:16, > from include/linux/async.h:14, > from kernel/async.c:47: > include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE > 1156 | #error Allocator MAX_ORDER exceeds SECTION_SIZE > | ^~~~~ > > The error cause is the missing definition of PAGE_SHIFT in the calculation > of SECTION_SIZE_BITS. > > Add include of to arch/ia64/include/asm/sparsemem.h to solve > the problem. > > Fixes: 214496cb1870 ("ia64: make SPARSEMEM default and disable DISCONTIGMEM") > Reported-by: Guenter Roeck > Signed-off-by: Mike Rapoport > --- > > Surprisingly, only Guenter's bot caught this. > > @Andrew, if you prefer I can take this via memblock tree. > > arch/ia64/include/asm/sparsemem.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/ia64/include/asm/sparsemem.h b/arch/ia64/include/asm/sparsemem.h > index dd8c166ffd7b..42ed5248fae9 100644 > --- a/arch/ia64/include/asm/sparsemem.h > +++ b/arch/ia64/include/asm/sparsemem.h > @@ -3,6 +3,7 @@ > #define _ASM_IA64_SPARSEMEM_H > > #ifdef CONFIG_SPARSEMEM > +#include > /* > * SECTION_SIZE_BITS 2^N: how big each section will be > * MAX_PHYSMEM_BITS 2^N: how much memory we can have in that space > -- > 2.28.0 > -- Sincerely yours, Mike.