From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Dan Murphy <dmurphy@ti.com>, Sebastian Reichel <sre@kernel.org>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/3] mfd: Add driver for Embedded Controller found on Acer Iconia Tab A500
Date: Thu, 14 Jan 2021 13:47:53 +0000 [thread overview]
Message-ID: <20210114134753.GY3975472@dell> (raw)
In-Reply-To: <20201228160547.30562-3-digetx@gmail.com>
On Mon, 28 Dec 2020, Dmitry Osipenko wrote:
> Acer Iconia Tab A500 is an Android tablet device, it has ENE KB930
> Embedded Controller which provides battery-gauge, LED, GPIO and some
> other functions. The EC uses firmware that is specifically customized
> for Acer A500. This patch adds MFD driver for the Embedded Controller
> which allows to power-off / reboot the A500 device, it also provides
> a common register read/write API that will be used by the sub-devices.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/mfd/Kconfig | 11 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/acer-ec-a500.c | 202 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 214 insertions(+)
> create mode 100644 drivers/mfd/acer-ec-a500.c
Looks good to me:
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Do you have a merge plan?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-01-14 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 16:05 [PATCH v8 0/3] Introduce Embedded Controller driver for Acer A500 Dmitry Osipenko
2020-12-28 16:05 ` [PATCH v8 1/3] dt-bindings: mfd: Add ENE KB930 Embedded Controller binding Dmitry Osipenko
2021-01-14 14:27 ` Lee Jones
2020-12-28 16:05 ` [PATCH v8 2/3] mfd: Add driver for Embedded Controller found on Acer Iconia Tab A500 Dmitry Osipenko
2021-01-14 13:47 ` Lee Jones [this message]
2021-01-14 14:12 ` Dmitry Osipenko
2021-01-14 14:28 ` Lee Jones
2020-12-28 16:05 ` [PATCH v8 3/3] power: supply: Add battery gauge driver for " Dmitry Osipenko
2021-01-14 18:49 ` Sebastian Reichel
2021-01-12 6:59 ` [PATCH v8 0/3] Introduce Embedded Controller driver for Acer A500 Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114134753.GY3975472@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dmurphy@ti.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox