From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Corey Minyard <minyard@acm.org>
Cc: linux-i2c@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>,
Vijay Khemka <vijaykhemka@fb.com>,
Asmaa Mnebhi <Asmaa@mellanox.com>
Subject: Re: [PATCH RFC 3/3] ipmi: remove open coded version of SMBus block write
Date: Thu, 14 Jan 2021 15:04:01 +0100 [thread overview]
Message-ID: <20210114140401.GA973@kunai> (raw)
In-Reply-To: <20210114004822.GY3348@minyard.net>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
> I asked the original authors of this about the change, and apparently is
> results in a stack size warning. Arnd Bergmann ask for it to be changed
> from what you are suggesting to what it currently is. See:
>
> https://www.lkml.org/lkml/2019/6/19/440
>
> So apparently this change will cause compile warnings due to the size of
> struct i2c_client.
Wow, didn't know that my patch was actually a revert. I replaced now the
stack usage with kmemdup and will have a second thought about this
patch. Thanks for the heads up!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-01-14 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 16:41 [PATCH RFC 0/3] treewide: remove open coded SMBus block transfers Wolfram Sang
2021-01-12 16:41 ` [PATCH RFC 1/3] media: i2c: adv7842: remove open coded version of SMBus block write Wolfram Sang
2021-01-18 9:24 ` Hans Verkuil
2021-01-18 9:32 ` Wolfram Sang
2021-01-12 16:41 ` [PATCH RFC 2/3] media: i2c: adv7842: remove open coded version of SMBus block read Wolfram Sang
2021-01-12 16:44 ` Wolfram Sang
2021-01-12 19:41 ` Wolfram Sang
2021-01-18 9:22 ` Hans Verkuil
2021-01-18 9:33 ` Wolfram Sang
2021-01-12 16:41 ` [PATCH RFC 3/3] ipmi: remove open coded version of SMBus block write Wolfram Sang
2021-01-14 0:48 ` Corey Minyard
2021-01-14 14:04 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114140401.GA973@kunai \
--to=wsa+renesas@sang-engineering.com \
--cc=Asmaa@mellanox.com \
--cc=colin.king@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=vijaykhemka@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox