From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/bootconfig: Add tracing_on support to helper scripts
Date: Thu, 14 Jan 2021 15:50:34 +0900 [thread overview]
Message-ID: <20210114155034.1132dc7d1c80a3da6a26d554@kernel.org> (raw)
In-Reply-To: <20210113181158.1b9df04c@gandalf.local.home>
On Wed, 13 Jan 2021 18:11:58 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Just noticed this patch. I'm adding it into my queue for the next merge
> window, as it doesn't look too urgent.
Yes, it is not urgent, but it might be better to backport to 5.10.
Thank you,
>
> -- Steve
>
>
> On Wed, 9 Dec 2020 14:27:44 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Add ftrace.instance.INSTANCE.tracing_on support to ftrace2bconf.sh
> > and bconf2ftrace.sh.
> >
> > commit 8490db06f914 ("tracing/boot: Add per-instance tracing_on
> > option support") added the per-instance tracing_on option,
> > but forgot to update the helper scripts.
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > tools/bootconfig/scripts/bconf2ftrace.sh | 1 +
> > tools/bootconfig/scripts/ftrace2bconf.sh | 4 ++++
> > 2 files changed, 5 insertions(+)
> >
> > diff --git a/tools/bootconfig/scripts/bconf2ftrace.sh b/tools/bootconfig/scripts/bconf2ftrace.sh
> > index 595e164dc352..feb30c2c7881 100755
> > --- a/tools/bootconfig/scripts/bconf2ftrace.sh
> > +++ b/tools/bootconfig/scripts/bconf2ftrace.sh
> > @@ -152,6 +152,7 @@ setup_instance() { # [instance]
> > set_array_of ${instance}.options ${instancedir}/trace_options
> > set_value_of ${instance}.trace_clock ${instancedir}/trace_clock
> > set_value_of ${instance}.cpumask ${instancedir}/tracing_cpumask
> > + set_value_of ${instance}.tracing_on ${instancedir}/tracing_on
> > set_value_of ${instance}.tracer ${instancedir}/current_tracer
> > set_array_of ${instance}.ftrace.filters \
> > ${instancedir}/set_ftrace_filter
> > diff --git a/tools/bootconfig/scripts/ftrace2bconf.sh b/tools/bootconfig/scripts/ftrace2bconf.sh
> > index 6c0d4b61e0c2..a0c3bcc6da4f 100755
> > --- a/tools/bootconfig/scripts/ftrace2bconf.sh
> > +++ b/tools/bootconfig/scripts/ftrace2bconf.sh
> > @@ -221,6 +221,10 @@ instance_options() { # [instance-name]
> > if [ `echo $val | sed -e s/f//g`x != x ]; then
> > emit_kv $PREFIX.cpumask = $val
> > fi
> > + val=`cat $INSTANCE/tracing_on`
> > + if [ `echo $val | sed -e s/f//g`x != x ]; then
> > + emit_kv $PREFIX.tracing_on = $val
> > + fi
> >
> > val=
> > for i in `cat $INSTANCE/set_event`; do
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-01-14 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 5:27 [PATCH] tools/bootconfig: Add tracing_on support to helper scripts Masami Hiramatsu
2021-01-13 23:11 ` Steven Rostedt
2021-01-14 6:50 ` Masami Hiramatsu [this message]
2021-01-14 14:44 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114155034.1132dc7d1c80a3da6a26d554@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox