From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE7FDC433E0 for ; Thu, 14 Jan 2021 16:43:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A835323B1C for ; Thu, 14 Jan 2021 16:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726301AbhANQni convert rfc822-to-8bit (ORCPT ); Thu, 14 Jan 2021 11:43:38 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:59563 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbhANQni (ORCPT ); Thu, 14 Jan 2021 11:43:38 -0500 X-Originating-IP: 86.201.233.230 Received: from xps13 (lfbn-tou-1-151-230.w86-201.abo.wanadoo.fr [86.201.233.230]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C36E6E0013; Thu, 14 Jan 2021 16:42:55 +0000 (UTC) Date: Thu, 14 Jan 2021 17:42:54 +0100 From: Miquel Raynal To: Manivannan Sadhasivam Cc: Md Sadre Alam , richard@nod.at, vigneshr@ti.com, boris.brezillon@collabora.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH V3] mtd: rawnand: qcom: update last code word register Message-ID: <20210114174254.55bd0083@xps13> In-Reply-To: <20210114163154.GA76759@thinkpad> References: <1610251305-20792-1-git-send-email-mdalam@codeaurora.org> <20210114165325.3d510355@xps13> <20210114163154.GA76759@thinkpad> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Manivannan, Manivannan Sadhasivam wrote on Thu, 14 Jan 2021 22:01:54 +0530: > On Thu, Jan 14, 2021 at 04:53:25PM +0100, Miquel Raynal wrote: > > Hello, > > > > Md Sadre Alam wrote on Sun, 10 Jan 2021 > > 09:31:45 +0530: > > > > > From QPIC version 2.0 onwards new register got added to > > > > a > > > > > read last codeword. This change will update the same. > > > > the? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Please reword this sentence. > > > > > For first three code word READ_LOCATION_n register will be > > > use.For last code word READ_LOCATION_LAST_CW_n register will be > > > use. > > > > "For the first three codewords, READ_LOCATION_n registers will be used. > > The last codeword register will be accessed through > > READ_LOCATION_LAST_CW_n." > > > > Also, please specify what these registers store. > > > > > Signed-off-by: Md Sadre Alam > > > > Could someone please test this patch? > > > > This is on my TODO list. Will get back to it once I'm back from holidays > or sooner if I find some time in the middle. No hurry, I believe this patch still needs a little bit of effort before being ready for upstreaming. Thanks, Miquèl