Re: [PATCH 5.10 086/103] regmap: debugfs: Fix a memory leak when calling regmap_attach_dev

Pavel Machek
2021-01-15T20:19:25Z

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

Hi!

> From: Xiaolei Wang <xiaolei.wang@windriver.com>
>
> commit cffa4b2122f5f3e53cf3d529bbc74651f95856d5 upstream.
>
> After initializing the regmap through
> syscon_regmap_lookup_by_compatible, then regmap_attach_dev to the
> device, because the debugfs_name has been allocated, there is no
> need to redistribute it again

? redistribute?

Anyway, this patch is clearly buggy:

>
> if (!strcmp(name, "dummy")) {
> - kfree(map->debugfs_name);
> + if (!map->debugfs_name)
> + kfree(map->debugfs_name);
>

It runs kfree only if the variable is NULL. That's clearly useless,
kfree(NULL) is NOP, and this causes memory leak.

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]