From: kernel test robot <lkp@intel.com>
To: Elena Petrova <lenaptr@google.com>, kvmarm@lists.cs.columbia.edu
Cc: kbuild-all@lists.01.org, Elena Petrova <lenaptr@google.com>,
linux-arm-kernel@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
George Popescu <george.apopescu97@gmail.com>
Subject: Re: [PATCH v2 2/9] KVM: arm64: Add a buffer that can pass UBSan data from hyp/nVHE to kernel
Date: Fri, 15 Jan 2021 20:35:59 +0800 [thread overview]
Message-ID: <202101152038.7xRQChwH-lkp@intel.com> (raw)
In-Reply-To: <20210114172338.2798389-3-lenaptr@google.com>
[-- Attachment #1: Type: text/plain, Size: 6681 bytes --]
Hi Elena,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[cannot apply to kvmarm/next soc/for-next arm/for-next xlnx/master v5.11-rc3 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Elena-Petrova/UBSan-Enablement-for-hyp-nVHE-code/20210115-112509
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/aba3219bbab3bb5c7f037fe7b6c6c783942bc954
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Elena-Petrova/UBSan-Enablement-for-hyp-nVHE-code/20210115-112509
git checkout aba3219bbab3bb5c7f037fe7b6c6c783942bc954
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/arm64/kvm/hyp/nvhe/ubsan.c:9:
>> arch/arm64/kvm/hyp/nvhe/ubsan.c:18:48: error: conflicting types for 'kvm_ubsan_buffer'
18 | DEFINE_KVM_DEBUG_BUFFER(struct kvm_ubsan_info, kvm_ubsan_buffer,
| ^~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:95:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
95 | __PCPU_ATTRS(sec) __weak __typeof__(type) name
| ^~~~
arch/arm64/include/asm/kvm_debug_buffer.h:14:2: note: in expansion of macro 'DEFINE_PER_CPU'
14 | DEFINE_PER_CPU(type_name, buffer_name)[size]; \
| ^~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:18:1: note: in expansion of macro 'DEFINE_KVM_DEBUG_BUFFER'
18 | DEFINE_KVM_DEBUG_BUFFER(struct kvm_ubsan_info, kvm_ubsan_buffer,
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:18:48: note: previous declaration of 'kvm_ubsan_buffer' was here
18 | DEFINE_KVM_DEBUG_BUFFER(struct kvm_ubsan_info, kvm_ubsan_buffer,
| ^~~~~~~~~~~~~~~~
include/linux/percpu-defs.h:94:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
94 | extern __PCPU_ATTRS(sec) __typeof__(type) name; \
| ^~~~
arch/arm64/include/asm/kvm_debug_buffer.h:14:2: note: in expansion of macro 'DEFINE_PER_CPU'
14 | DEFINE_PER_CPU(type_name, buffer_name)[size]; \
| ^~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:18:1: note: in expansion of macro 'DEFINE_KVM_DEBUG_BUFFER'
18 | DEFINE_KVM_DEBUG_BUFFER(struct kvm_ubsan_info, kvm_ubsan_buffer,
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:33:6: warning: no previous prototype for '__ubsan_handle_add_overflow' [-Wmissing-prototypes]
33 | void __ubsan_handle_add_overflow(void *_data, void *lhs, void *rhs) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:35:6: warning: no previous prototype for '__ubsan_handle_sub_overflow' [-Wmissing-prototypes]
35 | void __ubsan_handle_sub_overflow(void *_data, void *lhs, void *rhs) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:37:6: warning: no previous prototype for '__ubsan_handle_mul_overflow' [-Wmissing-prototypes]
37 | void __ubsan_handle_mul_overflow(void *_data, void *lhs, void *rhs) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:39:6: warning: no previous prototype for '__ubsan_handle_negate_overflow' [-Wmissing-prototypes]
39 | void __ubsan_handle_negate_overflow(void *_data, void *old_val) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:41:6: warning: no previous prototype for '__ubsan_handle_divrem_overflow' [-Wmissing-prototypes]
41 | void __ubsan_handle_divrem_overflow(void *_data, void *lhs, void *rhs) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:43:6: warning: no previous prototype for '__ubsan_handle_type_mismatch' [-Wmissing-prototypes]
43 | void __ubsan_handle_type_mismatch(struct type_mismatch_data *data, void *ptr) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:45:6: warning: no previous prototype for '__ubsan_handle_type_mismatch_v1' [-Wmissing-prototypes]
45 | void __ubsan_handle_type_mismatch_v1(void *_data, void *ptr) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:47:6: warning: no previous prototype for '__ubsan_handle_out_of_bounds' [-Wmissing-prototypes]
47 | void __ubsan_handle_out_of_bounds(void *_data, void *index) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:49:6: warning: no previous prototype for '__ubsan_handle_shift_out_of_bounds' [-Wmissing-prototypes]
49 | void __ubsan_handle_shift_out_of_bounds(void *_data, void *lhs, void *rhs) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:51:6: warning: no previous prototype for '__ubsan_handle_builtin_unreachable' [-Wmissing-prototypes]
51 | void __ubsan_handle_builtin_unreachable(void *_data) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/hyp/nvhe/ubsan.c:53:6: warning: no previous prototype for '__ubsan_handle_load_invalid_value' [-Wmissing-prototypes]
53 | void __ubsan_handle_load_invalid_value(void *_data, void *val) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/kvm_ubsan_buffer +18 arch/arm64/kvm/hyp/nvhe/ubsan.c
> 9 #include <linux/percpu-defs.h>
10 #include <linux/kvm_host.h>
11 #include <asm/kvm_arm.h>
12 #include <asm/kvm_asm.h>
13 #include <asm/kvm_ubsan.h>
14 #include <asm/kvm_debug_buffer.h>
15 #include <kvm/arm_pmu.h>
16 #include <ubsan.h>
17
> 18 DEFINE_KVM_DEBUG_BUFFER(struct kvm_ubsan_info, kvm_ubsan_buffer,
19 kvm_ubsan_buff_wr_ind, KVM_UBSAN_BUFFER_SIZE);
20
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 76484 bytes --]
next prev parent reply other threads:[~2021-01-15 12:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 17:23 [PATCH v2 0/9] UBSan Enablement for hyp/nVHE code Elena Petrova
2021-01-14 17:23 ` [PATCH v2 1/9] KVM: arm64: Enable UBSan instrumentation in nVHE hyp code Elena Petrova
2021-01-15 8:53 ` kernel test robot
2021-01-14 17:23 ` [PATCH v2 2/9] KVM: arm64: Add a buffer that can pass UBSan data from hyp/nVHE to kernel Elena Petrova
2021-01-15 9:54 ` kernel test robot
2021-01-15 12:35 ` kernel test robot [this message]
2021-01-14 17:23 ` [PATCH v2 3/9] KVM: arm64: Enable UBSAN_BOUNDS for the both the kernel and hyp/nVHE Elena Petrova
2021-01-15 13:37 ` kernel test robot
2021-01-14 17:23 ` [PATCH v2 4/9] KVM: arm64: Enable UBsan check for unreachable code inside hyp/nVHE code Elena Petrova
2021-01-14 17:23 ` [PATCH v2 5/9] KVM: arm64: Enable shift out of bounds undefined behaviour check for hyp/nVHE Elena Petrova
2021-01-14 17:23 ` [PATCH v2 6/9] KVM: arm64: __ubsan_handle_load_invalid_value EL2 implementation Elena Petrova
2021-01-14 17:23 ` [PATCH v2 7/9] KVM: arm64: Detect type mismatch undefined behaviour from hyp/nVHE code Elena Petrova
2021-01-14 17:23 ` [PATCH v2 8/9] KVM: arm64: Detect arithmetic overflow is inside hyp/nVHE Elena Petrova
2021-01-14 17:23 ` [PATCH v2 9/9] KVM: arm64: Add UBSan tests for PKVM Elena Petrova
2021-01-15 14:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101152038.7xRQChwH-lkp@intel.com \
--to=lkp@intel.com \
--cc=george.apopescu97@gmail.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=lenaptr@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox