Re: [PATCH v3 03/12] opp: Correct debug message in _opp_add_static_v2()

Viresh Kumar
2021-01-18T08:15:58Z

On 18-01-21, 03:55, Dmitry Osipenko wrote:
> The debug message always prints rate=0 instead of a proper value, fix it.
>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
> Tested-by: Matt Merhar <mattmerhar@protonmail.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/opp/of.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 50df483c7dc3..63b16cdba5ea 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -755,7 +755,6 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table,
> struct device *dev, struct device_node *np)
> {
> struct dev_pm_opp *new_opp;
> - u64 rate = 0;
> u32 val;
> int ret;
> bool rate_not_available = false;
> @@ -772,7 +771,8 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table,
>
> /* Check if the OPP supports hardware's hierarchy of versions or not */
> if (!_opp_is_supported(dev, opp_table, np)) {
> - dev_dbg(dev, "OPP not supported by hardware: %llu\n", rate);
> + dev_dbg(dev, "OPP not supported by hardware: %lu\n",
> + new_opp->rate);
> goto free_opp;
> }
>

Applied and added Fixes tag. Thanks.

--
viresh