Re: [PATCH v2 11/13] regulator: hi6421v600-regulator: move it from staging

Mark Brown
2021-01-18T16:22:28Z

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

On Mon, Jan 18, 2021 at 05:02:45PM +0100, Mauro Carvalho Chehab wrote:
> Mark Brown <broonie@kernel.org> escreveu:

> > If for some reason the PMIC is sufficiently fragile to need a delay
> > between enables it's not clear why the driver is doing it before
> > enabling rather than after, presumably there's issues with the regulator
> > ramping up and stabalising its output

> I don't have any datasheets or documentation from this device, except for
> the Linaro's official driver for Kernel 4.9 (from where this driver
> was originally ported), and a high-level documentation for this
> hardware at 96boards site, which doesn't cover any details.

This misses the point. To repeat, if the driver is hard coding
a delay why is the driver doing this *before* rather than *after*
enabling?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]