Re: [PATCH v2 10/13] mfd: hi6421-spmi-pmic: move driver from staging

Lee Jones
2021-01-18T15:51:55Z

On Mon, 18 Jan 2021, Mauro Carvalho Chehab wrote:

> Em Mon, 18 Jan 2021 15:12:27 +0000
> Lee Jones <lee.jones@linaro.org> escreveu:
>
> > On Mon, 18 Jan 2021, Mauro Carvalho Chehab wrote:
> >
> > > This driver is ready for mainstream. So, move it out of staging.
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > > ---
> > > .../mfd/hisilicon,hi6421-spmi-pmic.yaml | 133 +++++++
> > > MAINTAINERS | 7 +
> > > drivers/mfd/Kconfig | 15 +
> > > drivers/mfd/Makefile | 1 +
> > > drivers/mfd/hi6421-spmi-pmic.c | 342 ++++++++++++++++++
> > > drivers/staging/hikey9xx/Kconfig | 16 -
> > > drivers/staging/hikey9xx/Makefile | 1 -
> > > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 342 ------------------
> > > .../hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 133 -------
> > > 9 files changed, 498 insertions(+), 492 deletions(-)
> >
> > Could you please resubmit this will the correct flags.
> >
> > I believe it's the `git format-patch` -M flag that you want.
>
> As explained at patch 00/13, this was intentionally generated with
> --no-merges, in order to allow reviewers to view the entire source
> code at the patch.

That's a fair point. Please leave it as it is for now then.

I'll get around to the review soon I hope.

> Anyway, I'll re-send the series with -M, as it makes easier to merge,
> if everything is ok.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog