From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3438AC433DB for ; Mon, 18 Jan 2021 19:58:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D0CF22D49 for ; Mon, 18 Jan 2021 19:58:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436792AbhART6X (ORCPT ); Mon, 18 Jan 2021 14:58:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437410AbhART5c (ORCPT ); Mon, 18 Jan 2021 14:57:32 -0500 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 688E1C061574 for ; Mon, 18 Jan 2021 11:56:52 -0800 (PST) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1l1adr-0036Zp-T9; Mon, 18 Jan 2021 19:56:48 +0000 Date: Mon, 18 Jan 2021 19:56:47 +0000 From: Al Viro To: Linus Torvalds Cc: Johannes Berg , Christoph Hellwig , Oliver Giles , Linux Kernel Mailing List , Greg Kroah-Hartman Subject: Re: Splicing to/from a tty Message-ID: <20210118195647.GA740243@zeniv-ca> References: <20210118085311.GA2735@lst.de> <20210118194545.GB736435@zeniv-ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2021 at 11:49:53AM -0800, Linus Torvalds wrote: > On Mon, Jan 18, 2021 at 11:45 AM Al Viro wrote: > > > > do_splice_direct() does something that do_splice() won't - it > > handles non-pipe to non-pipe case. Which is how sendfile(2) is > > normally used, of course. > > Yeah, I agree, it's better if we do the pipe case specially, but if > it's too painful for a stable backport I'll certainly take the > one-liner.. > > Btw, your email setup is broken. Your emails now have a "From:" line like this: > > From: Al Viro > > and that is not a valid email address. Just noticed, should be fixed now...