From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F69C433E9 for ; Tue, 19 Jan 2021 05:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B63FD22E01 for ; Tue, 19 Jan 2021 05:02:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389422AbhASE5n (ORCPT ); Mon, 18 Jan 2021 23:57:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389390AbhASEwH (ORCPT ); Mon, 18 Jan 2021 23:52:07 -0500 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 944FCC061573; Mon, 18 Jan 2021 20:51:27 -0800 (PST) Received: by mail-oi1-x22a.google.com with SMTP id d203so19979604oia.0; Mon, 18 Jan 2021 20:51:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YyUpixJdOFKDLwx0E5YLjJFkuvrbBxDPQNmPONztm6I=; b=LMX8+uwpqdNEXFDvRTkuqF+zOOFUp64zE4GT2cQ+/U4Z67cjiEvqlmEbGnk7jBlFqb IsfvV9CVRxojoyeKSwhABQfOTxKvlCCYOvqlujV+B3MCYPnV+Cel2Ytqn2zExqq0OO+T jztrqBwzUmCOuJfpu73MgF+UAVV0zCYKZ+1MEuObZRfFo7kh4crAGDgk7BAhE9KzyKzk XM4KAd4FqZ0SngOpbGq9TS9XeV5g+ge4lGHI670qanzMQjrc5B514XfEBvJ93XxXw5Se lvB7GjYDacc2XZzRIsmFEuS9D7ovz66JfKGL8DH+UHFk8+rDWIIs93DvCDwBXmhtSdf/ 75sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YyUpixJdOFKDLwx0E5YLjJFkuvrbBxDPQNmPONztm6I=; b=liMM8oyeP0WcDetTpNjPdSvb3QIskhvmyAf7UKVd4byERGYbbaBNJ0BjAXnWHvzu4b uYmCYG3WohoHIxWdBx5Tu3eOke2lzpYMyUXomp5ZgbP5RIcOna4Pvh6jN6GfSC2twk7w pKCSeXZ8Forf1Q8q4BsDgmkAFN0hJta5uz0xu0BhxxTDVXE3BqRPS+tOtL9bHhGScz+7 r4mOq5QtsnaFHkQJKtpBLr/KGTtJFxoTZzcUW8SgGayJ6dKhInzCRNQtf7PDvIleHS2p Mshwnbv8g90XiPPqxKd+TdViqBwvK0b7cU7MDZdZiXO+g18kBBFFXqpD+UmVwMnAzJ0R +ICQ== X-Gm-Message-State: AOAM533U1Q7BW4tAbTNcDZ7tHkYHF3VYds3s3LuAgGlhgaCZkziYS8Iz NZ32XCyNKBf9MYCoM1qMrhY= X-Google-Smtp-Source: ABdhPJwTFgRyM9aXittIDXrWXQYpGEIiPG1accCJ4rcXgle4i8zzIDyRzBIEZzpjKzTLG+4tARhFhw== X-Received: by 2002:aca:f44f:: with SMTP id s76mr1601888oih.120.1611031886945; Mon, 18 Jan 2021 20:51:26 -0800 (PST) Received: from localhost.localdomain (99-6-134-177.lightspeed.snmtca.sbcglobal.net. [99.6.134.177]) by smtp.gmail.com with ESMTPSA id s24sm3694402oij.20.2021.01.18.20.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 20:51:26 -0800 (PST) Date: Mon, 18 Jan 2021 20:51:23 -0800 From: Enke Chen To: Jakub Kicinski Cc: "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Eric Dumazet , Yuchung Cheng , Soheil Hassas Yeganeh , Neal Cardwell , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Maxwell , William McCall , enkechen2020@gmail.com Subject: Re: [PATCH net v2] tcp: fix TCP_USER_TIMEOUT with zero window Message-ID: <20210119045123.GA26806@localhost.localdomain> References: <20210115223058.GA39267@localhost.localdomain> <20210118200221.73033add@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210118200221.73033add@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2021 at 08:02:21PM -0800, Jakub Kicinski wrote: > On Fri, 15 Jan 2021 14:30:58 -0800 Enke Chen wrote: > > From: Enke Chen > > > > The TCP session does not terminate with TCP_USER_TIMEOUT when data > > remain untransmitted due to zero window. > > > > The number of unanswered zero-window probes (tcp_probes_out) is > > reset to zero with incoming acks irrespective of the window size, > > as described in tcp_probe_timer(): > > > > RFC 1122 4.2.2.17 requires the sender to stay open indefinitely > > as long as the receiver continues to respond probes. We support > > this by default and reset icsk_probes_out with incoming ACKs. > > > > This counter, however, is the wrong one to be used in calculating the > > duration that the window remains closed and data remain untransmitted. > > Thanks to Jonathan Maxwell for diagnosing the > > actual issue. > > > > In this patch a new timestamp is introduced for the socket in order to > > track the elapsed time for the zero-window probes that have not been > > answered with any non-zero window ack. > > > > Fixes: 9721e709fa68 ("tcp: simplify window probe aborting on USER_TIMEOUT") > > Reported-by: William McCall > > Co-developed-by: Neal Cardwell > > Signed-off-by: Neal Cardwell > > Signed-off-by: Enke Chen > > Reviewed-by: Yuchung Cheng > > Reviewed-by: Eric Dumazet > > I take it you got all these tags off-list? I don't see them on the v1 > discussion. Yes, the tags have been approved off-list by those named. > > Applied to net, thanks! Thanks. -- Enke