From: Shawn Guo <shawn.guo@linaro.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
vgarodia@codeaurora.org,
Mansur Alisha Shaik <mansur@codeaurora.org>
Subject: Re: [PATCH] venus: core: Fix platform driver shutdown
Date: Tue, 19 Jan 2021 15:40:45 +0800 [thread overview]
Message-ID: <20210119074044.GB17701@dragon> (raw)
In-Reply-To: <20201221095820.27192-1-stanimir.varbanov@linaro.org>
On Mon, Dec 21, 2020 at 11:58:20AM +0200, Stanimir Varbanov wrote:
> With TZ system reboot cannot finish successfully. To fix that
> enable core clocks by runtime pm before TZ calls and disable
> clocks after that.
>
> Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus")
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Hi Mauro,
Could you help pick this fix up?
Shawn
> ---
> drivers/media/platform/qcom/venus/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index bdd293faaad0..7233a7311757 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -349,8 +349,10 @@ static void venus_core_shutdown(struct platform_device *pdev)
> {
> struct venus_core *core = platform_get_drvdata(pdev);
>
> + pm_runtime_get_sync(core->dev);
> venus_shutdown(core);
> venus_firmware_deinit(core);
> + pm_runtime_put_sync(core->dev);
> }
>
> static __maybe_unused int venus_runtime_suspend(struct device *dev)
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-01-19 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 9:58 [PATCH] venus: core: Fix platform driver shutdown Stanimir Varbanov
2020-12-21 10:40 ` Shawn Guo
2021-01-19 7:40 ` Shawn Guo [this message]
2021-01-19 7:59 ` Stanimir Varbanov
2021-01-19 8:22 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119074044.GB17701@dragon \
--to=shawn.guo@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mansur@codeaurora.org \
--cc=mchehab+huawei@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox