From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0427C433E0 for ; Tue, 19 Jan 2021 07:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 927072312D for ; Tue, 19 Jan 2021 07:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbhASHnp (ORCPT ); Tue, 19 Jan 2021 02:43:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730702AbhASHld (ORCPT ); Tue, 19 Jan 2021 02:41:33 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC25AC0613C1 for ; Mon, 18 Jan 2021 23:40:52 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id t29so6605762pfg.11 for ; Mon, 18 Jan 2021 23:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9avt2pOBcvJfq1YOSVtKJyXRfPA6gi4W3HN8JdFkr7E=; b=H7u0aSET/08uKmaL90MaLtrCKKWIVTcDGAfQcXL7yEfeXS2W1ILnwX5b28nS5cuogI FcX5aPzkZvPi18mXmJ8dIcmiYm1Ry0ItT9HUaM/o+iXs6Kp8Dk20cz+ysMedb2uH112p xogjdOySkTDvzejIdx3dWdt5599EyodIBlZC79zC0RUqMJ7hgu8ZEdSbu5aPq+JUNOfd NuuWtk9YYCO8MJJpBHSZM/jazTzJB19IfAtzHHcOZ2HiiGGzrKBTIizgKCZ9J0MF5k/x HOaYdH1e3/Cx0i4n1C936ALNLfxuBo2AaPD6H7EVJC24AWaJDv91/PIWMxc3/HEHdsdQ z+9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9avt2pOBcvJfq1YOSVtKJyXRfPA6gi4W3HN8JdFkr7E=; b=VqZBvw3UZ8dKwsyBrWtK5z8tV8pKBMpp22pUJd2KXnzwz+SakVIF6IFzSU0xr48Jhh ekkWeEqB82Pe/PDxtFZ6sei+Oye4wkv0ksa7oRIo5a+a9OE2wOUAdWp/Rbb/kLrKzL9W UuCxdS2JxNMndSBmrrai5xlIXc/sZdhJpNPKYgpELNAekD0c9OxiZVinIh7vJO3lGifW VfqqsnRgQb9wsdKazs9LjG0EGYxAdEnWuSIe0R4+SXJ3s/rGbppBBV9FczFoL8oqwDa2 F8rkj0GChJc5jLPNpXH79m9tLKkRfyBqDEgGgIyko/Jsrb9Jrwry+WmLln6jnZvUn9zD dcgQ== X-Gm-Message-State: AOAM533P5DynKpFWsqxq2kXPRWk6C6SgiW/Pip5WdIH/EDUporG1xn7y 4t0n0HJrV8BoECcX5vS0jDaFLA== X-Google-Smtp-Source: ABdhPJy90mTIjMN6C//R3eawLVr0JtAtTzJ6ix8X3qtKcBMdssq6bTuEaSVX+ktT80LWYM9GFCIWNg== X-Received: by 2002:a65:5244:: with SMTP id q4mr3354534pgp.50.1611042052159; Mon, 18 Jan 2021 23:40:52 -0800 (PST) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id fh15sm2057724pjb.32.2021.01.18.23.40.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jan 2021 23:40:51 -0800 (PST) Date: Tue, 19 Jan 2021 15:40:45 +0800 From: Shawn Guo To: Stanimir Varbanov , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , vgarodia@codeaurora.org, Mansur Alisha Shaik Subject: Re: [PATCH] venus: core: Fix platform driver shutdown Message-ID: <20210119074044.GB17701@dragon> References: <20201221095820.27192-1-stanimir.varbanov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201221095820.27192-1-stanimir.varbanov@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 21, 2020 at 11:58:20AM +0200, Stanimir Varbanov wrote: > With TZ system reboot cannot finish successfully. To fix that > enable core clocks by runtime pm before TZ calls and disable > clocks after that. > > Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus") > Signed-off-by: Stanimir Varbanov Hi Mauro, Could you help pick this fix up? Shawn > --- > drivers/media/platform/qcom/venus/core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index bdd293faaad0..7233a7311757 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -349,8 +349,10 @@ static void venus_core_shutdown(struct platform_device *pdev) > { > struct venus_core *core = platform_get_drvdata(pdev); > > + pm_runtime_get_sync(core->dev); > venus_shutdown(core); > venus_firmware_deinit(core); > + pm_runtime_put_sync(core->dev); > } > > static __maybe_unused int venus_runtime_suspend(struct device *dev) > -- > 2.17.1 >