* [PATCH] venus: core: Fix platform driver shutdown
@ 2020-12-21 9:58 Stanimir Varbanov
2020-12-21 10:40 ` Shawn Guo
2021-01-19 7:40 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Stanimir Varbanov @ 2020-12-21 9:58 UTC (permalink / raw)
To: linux-media, linux-arm-msm, linux-kernel
Cc: Bjorn Andersson, Shawn Guo, vgarodia, Mansur Alisha Shaik,
Stanimir Varbanov
With TZ system reboot cannot finish successfully. To fix that
enable core clocks by runtime pm before TZ calls and disable
clocks after that.
Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus")
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
drivers/media/platform/qcom/venus/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index bdd293faaad0..7233a7311757 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -349,8 +349,10 @@ static void venus_core_shutdown(struct platform_device *pdev)
{
struct venus_core *core = platform_get_drvdata(pdev);
+ pm_runtime_get_sync(core->dev);
venus_shutdown(core);
venus_firmware_deinit(core);
+ pm_runtime_put_sync(core->dev);
}
static __maybe_unused int venus_runtime_suspend(struct device *dev)
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] venus: core: Fix platform driver shutdown
2020-12-21 9:58 [PATCH] venus: core: Fix platform driver shutdown Stanimir Varbanov
@ 2020-12-21 10:40 ` Shawn Guo
2021-01-19 7:40 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2020-12-21 10:40 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: linux-media, linux-arm-msm, Linux Kernel Mailing List,
Bjorn Andersson, vgarodia, Mansur Alisha Shaik
On Mon, Dec 21, 2020 at 5:58 PM Stanimir Varbanov
<stanimir.varbanov@linaro.org> wrote:
>
> With TZ system reboot cannot finish successfully. To fix that
> enable core clocks by runtime pm before TZ calls and disable
> clocks after that.
>
> Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus")
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
It fixes reboot on Lenovo Yoga C630 laptop for me, so:
Tested-by: Shawn Guo <shawn.guo@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] venus: core: Fix platform driver shutdown
2020-12-21 9:58 [PATCH] venus: core: Fix platform driver shutdown Stanimir Varbanov
2020-12-21 10:40 ` Shawn Guo
@ 2021-01-19 7:40 ` Shawn Guo
2021-01-19 7:59 ` Stanimir Varbanov
1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2021-01-19 7:40 UTC (permalink / raw)
To: Stanimir Varbanov, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Bjorn Andersson,
vgarodia, Mansur Alisha Shaik
On Mon, Dec 21, 2020 at 11:58:20AM +0200, Stanimir Varbanov wrote:
> With TZ system reboot cannot finish successfully. To fix that
> enable core clocks by runtime pm before TZ calls and disable
> clocks after that.
>
> Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus")
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Hi Mauro,
Could you help pick this fix up?
Shawn
> ---
> drivers/media/platform/qcom/venus/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index bdd293faaad0..7233a7311757 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -349,8 +349,10 @@ static void venus_core_shutdown(struct platform_device *pdev)
> {
> struct venus_core *core = platform_get_drvdata(pdev);
>
> + pm_runtime_get_sync(core->dev);
> venus_shutdown(core);
> venus_firmware_deinit(core);
> + pm_runtime_put_sync(core->dev);
> }
>
> static __maybe_unused int venus_runtime_suspend(struct device *dev)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] venus: core: Fix platform driver shutdown
2021-01-19 7:40 ` Shawn Guo
@ 2021-01-19 7:59 ` Stanimir Varbanov
2021-01-19 8:22 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Stanimir Varbanov @ 2021-01-19 7:59 UTC (permalink / raw)
To: Shawn Guo, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Bjorn Andersson,
vgarodia, Mansur Alisha Shaik
On 1/19/21 9:40 AM, Shawn Guo wrote:
> On Mon, Dec 21, 2020 at 11:58:20AM +0200, Stanimir Varbanov wrote:
>> With TZ system reboot cannot finish successfully. To fix that
>> enable core clocks by runtime pm before TZ calls and disable
>> clocks after that.
>>
>> Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus")
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>
> Hi Mauro,
>
> Could you help pick this fix up?
Shawn, it is part of linux-next already.
>
> Shawn
>
>> ---
>> drivers/media/platform/qcom/venus/core.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
>> index bdd293faaad0..7233a7311757 100644
>> --- a/drivers/media/platform/qcom/venus/core.c
>> +++ b/drivers/media/platform/qcom/venus/core.c
>> @@ -349,8 +349,10 @@ static void venus_core_shutdown(struct platform_device *pdev)
>> {
>> struct venus_core *core = platform_get_drvdata(pdev);
>>
>> + pm_runtime_get_sync(core->dev);
>> venus_shutdown(core);
>> venus_firmware_deinit(core);
>> + pm_runtime_put_sync(core->dev);
>> }
>>
>> static __maybe_unused int venus_runtime_suspend(struct device *dev)
>> --
>> 2.17.1
>>
--
regards,
Stan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] venus: core: Fix platform driver shutdown
2021-01-19 7:59 ` Stanimir Varbanov
@ 2021-01-19 8:22 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2021-01-19 8:22 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: Mauro Carvalho Chehab, linux-media, linux-arm-msm, linux-kernel,
Bjorn Andersson, vgarodia, Mansur Alisha Shaik
On Tue, Jan 19, 2021 at 09:59:41AM +0200, Stanimir Varbanov wrote:
> On 1/19/21 9:40 AM, Shawn Guo wrote:
> > On Mon, Dec 21, 2020 at 11:58:20AM +0200, Stanimir Varbanov wrote:
> >> With TZ system reboot cannot finish successfully. To fix that
> >> enable core clocks by runtime pm before TZ calls and disable
> >> clocks after that.
> >>
> >> Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus")
> >> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> >
> > Hi Mauro,
> >
> > Could you help pick this fix up?
>
> Shawn, it is part of linux-next already.
Ha, sorry, I did not check linux-next. I sent the message because
I see this fix is still missing after I rebase my Yoga C630 branch
to 5.11-rc4. We will get this fix into 5.11, right?
Shawn
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-19 8:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-21 9:58 [PATCH] venus: core: Fix platform driver shutdown Stanimir Varbanov
2020-12-21 10:40 ` Shawn Guo
2021-01-19 7:40 ` Shawn Guo
2021-01-19 7:59 ` Stanimir Varbanov
2021-01-19 8:22 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox