From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D10D0C433E0 for ; Tue, 19 Jan 2021 16:01:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9113E216FD for ; Tue, 19 Jan 2021 16:01:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391515AbhASQAq (ORCPT ); Tue, 19 Jan 2021 11:00:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:54040 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391693AbhASP6r (ORCPT ); Tue, 19 Jan 2021 10:58:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DE34FAE69; Tue, 19 Jan 2021 15:58:05 +0000 (UTC) Date: Tue, 19 Jan 2021 16:57:58 +0100 From: Borislav Petkov To: "Bae, Chang Seok" Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , x86-ml , "Brown, Len" , "Hansen, Dave" , "Liu, Jing2" , "Shankar, Ravi V" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 05/21] x86/fpu/xstate: Add a new variable to indicate dynamic user states Message-ID: <20210119155758.GF27634@zn.tnic> References: <20201223155717.19556-1-chang.seok.bae@intel.com> <20201223155717.19556-6-chang.seok.bae@intel.com> <20210115133924.GE11337@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2021 at 07:47:38PM +0000, Bae, Chang Seok wrote: > On Jan 15, 2021, at 05:39, Borislav Petkov wrote: > > On Wed, Dec 23, 2020 at 07:57:01AM -0800, Chang S. Bae wrote: > >> The perf has a buffer that is allocated on demand. The states saved in the > > > > What's "the perf"? I hope to find out when I countinue reading… > > Maybe it was better to write ‘Linux perf (tools)’ [1] here. Sorry for the > confusion. Well, I'm also confused as to what does the perf buffer have to do with AMX? > >> -#define XFEATURE_MASK_DYNAMIC (XFEATURE_MASK_LBR) > >> +#define XFEATURE_MASK_SUPERVISOR_DYNAMIC (XFEATURE_MASK_LBR) > > > > Is XFEATURE_MASK_USER_DYNAMIC coming too? > > Instead of the new define, I thought the new variable -- > xfeatures_mask_user_dynamic, as its value needs to be determined at boot > time. Why isn't that in your commit message? All I see a patch doing a bunch of renames, some unrelated blurb in the commit message and I have no clue what's going on here and why you're doing this. Your commit messages should contain simple english sentences and explain *why* the change is needed - not *what* you're doing. The *what* I can see from the diff itself, for the *why* I need a crystal ball which I can't buy in any store. So how about explaining the *why*? -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg