From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96778C433E0 for ; Tue, 19 Jan 2021 20:41:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E34D2310C for ; Tue, 19 Jan 2021 20:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727892AbhASUl2 (ORCPT ); Tue, 19 Jan 2021 15:41:28 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:3935 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388994AbhASUkW (ORCPT ); Tue, 19 Jan 2021 15:40:22 -0500 X-Originating-IP: 86.202.109.140 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 12767240002; Tue, 19 Jan 2021 20:39:38 +0000 (UTC) Date: Tue, 19 Jan 2021 21:39:38 +0100 From: Alexandre Belloni To: Steen Hegelund Cc: Philipp Zabel , Andrew Lunn , Microchip Linux Driver Support , Gregory Clement , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/3] reset: mchp: sparx5: add switch reset driver Message-ID: <20210119203938.GQ3666@piout.net> References: <20210114162432.3039657-1-steen.hegelund@microchip.com> <20210114162432.3039657-3-steen.hegelund@microchip.com> <20210119203710.GP3666@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210119203710.GP3666@piout.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/01/2021 21:37:16+0100, Alexandre Belloni wrote: > On 14/01/2021 17:24:31+0100, Steen Hegelund wrote: > > +static int sparx5_switch_reset(struct reset_controller_dev *rcdev, > > + unsigned long id) > > +{ > > + struct mchp_reset_context *ctx = > > + container_of(rcdev, struct mchp_reset_context, rcdev); > > + u32 val; > > + > > I would ensure the reset only happens once here else I'm not sure how > you could do it from the individual drivers. > Ok, the core is taking care of that, nice. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com