Re: [PATCH v3 2/6] ALSA: hda/tegra: Reset hardware

Takashi Iwai
2021-01-26T17:19:53Z

On Mon, 25 Jan 2021 16:27:30 +0100,
Dmitry Osipenko wrote:
>
> 25.01.2021 18:18, Takashi Iwai пишет:
> > On Wed, 20 Jan 2021 01:31:50 +0100,
> > Dmitry Osipenko wrote:
> >>
> >> Reset hardware on RPM-resume in order to bring it into a predictable
> >> state.
> >>
> >> Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30 audio works
> >> Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30 boot-tested
> >> Tested-by: Nicolas Chauvet <kwizart@gmail.com> # TK1 boot-tested
> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >
> > Currently we have neither dependency nor reverse-selection of
> > CONFIG_RESET_CONTROLLER. It wouldn't be a problem for builds, but
> > you'll get a runtime error from
> > devm_reset_control_array_get_exclusive() always when
> > CONFIG_RESET_CONTROLLER=n.
> >
> > I guess it must be a corner case, but just to be sure.
>
> The CONFIG_RESET_CONTROLLER=y at least for ARM32 Tegra builds.
>
> https://elixir.bootlin.com/linux/v5.11-rc5/source/arch/arm/mach-tegra/Kconfig#L15
>
> Not sure about ARM64.

OK, then it must be fine.
I applied now. Thanks.

Takashi