From: Yejune Deng <yejune.deng@gmail.com>
To: john.stultz@linaro.org, tglx@linutronix.de, sboyd@kernel.org
Cc: linux-kernel@vger.kernel.org, yejune.deng@gmail.com
Subject: [PATCH] ntp: use memset and offsetof init
Date: Wed, 20 Jan 2021 10:51:14 +0800 [thread overview]
Message-ID: <20210120025114.16294-1-yejune.deng@gmail.com> (raw)
In pps_fill_timex(), use memset and offsetof instead of '= 0'.
Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
---
kernel/time/ntp.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 87389b9e21ab..3416c0381104 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -225,14 +225,11 @@ static inline int is_error_status(int status)
static inline void pps_fill_timex(struct __kernel_timex *txc)
{
/* PPS is not implemented, so these are zero */
- txc->ppsfreq = 0;
- txc->jitter = 0;
- txc->shift = 0;
- txc->stabil = 0;
- txc->jitcnt = 0;
- txc->calcnt = 0;
- txc->errcnt = 0;
- txc->stbcnt = 0;
+ int offset, len;
+
+ offset = offsetof(struct __kernel_timex, ppsfreq);
+ len = offsetof(struct __kernel_timex, tai) - offset;
+ memset(txc + offset, 0, len);
}
#endif /* CONFIG_NTP_PPS */
--
2.29.0
next reply other threads:[~2021-01-20 3:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 2:51 Yejune Deng [this message]
2021-01-20 9:32 ` [kbuild] Re: [PATCH] ntp: use memset and offsetof init Dan Carpenter
2021-01-26 7:44 ` [ntp] a29bace5d3: BUG:Bad_rss-counter_state_mm:#type:MM_FILEPAGES_val kernel test robot
2021-02-05 17:33 ` [PATCH] ntp: use memset and offsetof init Thomas Gleixner
2021-02-08 9:28 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120025114.16294-1-yejune.deng@gmail.com \
--to=yejune.deng@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox