Re: [External] [PATCH v2 2/5] hugetlb: convert page_huge_active() HPageMigratable flag

Mike Kravetz
2021-02-04T00:46:40Z

On 2/2/21 11:42 PM, Muchun Song wrote:
> On Wed, Jan 20, 2021 at 9:33 AM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>
> Hi Mike,
>
> I found that you may forget to remove set_page_huge_active()
> from include/linux/hugetlb.h.
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 37fd248ce271..6f680cf0eee6 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -852,7 +852,7 @@ static inline void
> huge_ptep_modify_prot_commit(struct vm_area_struct *vma,
> }
> #endif
>
> -void set_page_huge_active(struct page *page);
> +
>
> Thanks.

Thank you Muchun for finding this.

Thank you Andrew for fixing in your tree.
--
Mike Kravetz