Re: [PATCH v2 1/5] hugetlb: use page.private for hugetlb specific page flags

kernel test robot
2021-01-20T08:46:59Z

[-- Attachment #1: Type: text/plain, Size: 11496 bytes --]

Hi Mike,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20210119]
[also build test ERROR on v5.11-rc4]
[cannot apply to linux/master linus/master hnaz-linux-mm/master v5.11-rc4 v5.11-rc3 v5.11-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Mike-Kravetz/create-hugetlb-flags-to-consolidate-state/20210120-142142
base: b4bb878f3eb3e604ebfe83bbc17eb7af8d99cbf4
config: nds32-defconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ebeb3dd25715894428a5107720212b022616c02f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mike-Kravetz/create-hugetlb-flags-to-consolidate-state/20210120-142142
git checkout ebeb3dd25715894428a5107720212b022616c02f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from kernel/fork.c:51:
include/linux/hugetlb.h: In function 'HPageRestoreReserve':
>> include/linux/hugetlb.h:512:11: error: expected ';' before '}' token
512 | return 0 }
| ^
include/linux/hugetlb.h:524:2: note: in expansion of macro 'TESTHPAGEFLAG'
524 | TESTHPAGEFLAG(uname, flname) \
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:531:1: note: in expansion of macro 'HPAGEFLAG'
531 | HPAGEFLAG(RestoreReserve, restore_reserve)
| ^~~~~~~~~
kernel/fork.c: At top level:
kernel/fork.c:161:13: warning: no previous prototype for 'arch_release_task_struct' [-Wmissing-prototypes]
161 | void __weak arch_release_task_struct(struct task_struct *tsk)
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/fork.c:746:20: warning: no previous prototype for 'arch_task_cache_init' [-Wmissing-prototypes]
746 | void __init __weak arch_task_cache_init(void) { }
| ^~~~~~~~~~~~~~~~~~~~
kernel/fork.c:836:12: warning: no previous prototype for 'arch_dup_task_struct' [-Wmissing-prototypes]
836 | int __weak arch_dup_task_struct(struct task_struct *dst,
| ^~~~~~~~~~~~~~~~~~~~
--
In file included from kernel/sysctl.c:45:
include/linux/hugetlb.h: In function 'HPageRestoreReserve':
>> include/linux/hugetlb.h:512:11: error: expected ';' before '}' token
512 | return 0 }
| ^
include/linux/hugetlb.h:524:2: note: in expansion of macro 'TESTHPAGEFLAG'
524 | TESTHPAGEFLAG(uname, flname) \
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:531:1: note: in expansion of macro 'HPAGEFLAG'
531 | HPAGEFLAG(RestoreReserve, restore_reserve)
| ^~~~~~~~~
--
In file included from include/linux/migrate.h:8,
from kernel/sched/sched.h:53,
from kernel/sched/core.c:13:
include/linux/hugetlb.h: In function 'HPageRestoreReserve':
>> include/linux/hugetlb.h:512:11: error: expected ';' before '}' token
512 | return 0 }
| ^
include/linux/hugetlb.h:524:2: note: in expansion of macro 'TESTHPAGEFLAG'
524 | TESTHPAGEFLAG(uname, flname) \
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:531:1: note: in expansion of macro 'HPAGEFLAG'
531 | HPAGEFLAG(RestoreReserve, restore_reserve)
| ^~~~~~~~~
kernel/sched/core.c: In function 'ttwu_stat':
kernel/sched/core.c:2955:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable]
2955 | struct rq *rq;
| ^~
kernel/sched/core.c: In function 'schedule_tail':
kernel/sched/core.c:4298:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable]
4298 | struct rq *rq;
| ^~
--
In file included from include/linux/migrate.h:8,
from kernel/sched/sched.h:53,
from kernel/sched/fair.c:23:
include/linux/hugetlb.h: In function 'HPageRestoreReserve':
>> include/linux/hugetlb.h:512:11: error: expected ';' before '}' token
512 | return 0 }
| ^
include/linux/hugetlb.h:524:2: note: in expansion of macro 'TESTHPAGEFLAG'
524 | TESTHPAGEFLAG(uname, flname) \
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:531:1: note: in expansion of macro 'HPAGEFLAG'
531 | HPAGEFLAG(RestoreReserve, restore_reserve)
| ^~~~~~~~~
kernel/sched/fair.c: At top level:
kernel/sched/fair.c:5399:6: warning: no previous prototype for 'init_cfs_bandwidth' [-Wmissing-prototypes]
5399 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
| ^~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11218:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes]
11218 | void free_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11220:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes]
11220 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11225:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes]
11225 | void online_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11227:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes]
11227 | void unregister_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from include/linux/migrate.h:8,
from kernel/sched/sched.h:53,
from kernel/sched/rt.c:6:
include/linux/hugetlb.h: In function 'HPageRestoreReserve':
>> include/linux/hugetlb.h:512:11: error: expected ';' before '}' token
512 | return 0 }
| ^
include/linux/hugetlb.h:524:2: note: in expansion of macro 'TESTHPAGEFLAG'
524 | TESTHPAGEFLAG(uname, flname) \
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:531:1: note: in expansion of macro 'HPAGEFLAG'
531 | HPAGEFLAG(RestoreReserve, restore_reserve)
| ^~~~~~~~~
kernel/sched/rt.c: At top level:
kernel/sched/rt.c:253:6: warning: no previous prototype for 'free_rt_sched_group' [-Wmissing-prototypes]
253 | void free_rt_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:255:5: warning: no previous prototype for 'alloc_rt_sched_group' [-Wmissing-prototypes]
255 | int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:669:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
669 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from include/linux/migrate.h:8,
from mm/page_alloc.c:61:
include/linux/hugetlb.h: In function 'HPageRestoreReserve':
>> include/linux/hugetlb.h:512:11: error: expected ';' before '}' token
512 | return 0 }
| ^
include/linux/hugetlb.h:524:2: note: in expansion of macro 'TESTHPAGEFLAG'
524 | TESTHPAGEFLAG(uname, flname) \
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:531:1: note: in expansion of macro 'HPAGEFLAG'
531 | HPAGEFLAG(RestoreReserve, restore_reserve)
| ^~~~~~~~~
mm/page_alloc.c: At top level:
mm/page_alloc.c:2618:5: warning: no previous prototype for 'find_suitable_fallback' [-Wmissing-prototypes]
2618 | int find_suitable_fallback(struct free_area *area, unsigned int order,
| ^~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c:3597:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
3597 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
| ^~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c:6257:23: warning: no previous prototype for 'memmap_init' [-Wmissing-prototypes]
6257 | void __meminit __weak memmap_init(unsigned long size, int nid,
| ^~~~~~~~~~~
--
In file included from fs/proc/meminfo.c:6:
include/linux/hugetlb.h: In function 'HPageRestoreReserve':
>> include/linux/hugetlb.h:512:11: error: expected ';' before '}' token
512 | return 0 }
| ^
include/linux/hugetlb.h:524:2: note: in expansion of macro 'TESTHPAGEFLAG'
524 | TESTHPAGEFLAG(uname, flname) \
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:531:1: note: in expansion of macro 'HPAGEFLAG'
531 | HPAGEFLAG(RestoreReserve, restore_reserve)
| ^~~~~~~~~
fs/proc/meminfo.c: At top level:
fs/proc/meminfo.c:22:28: warning: no previous prototype for 'arch_report_meminfo' [-Wmissing-prototypes]
22 | void __attribute__((weak)) arch_report_meminfo(struct seq_file *m)
| ^~~~~~~~~~~~~~~~~~~
--
In file included from kernel/events/core.c:31:
include/linux/hugetlb.h: In function 'HPageRestoreReserve':
>> include/linux/hugetlb.h:512:11: error: expected ';' before '}' token
512 | return 0 }
| ^
include/linux/hugetlb.h:524:2: note: in expansion of macro 'TESTHPAGEFLAG'
524 | TESTHPAGEFLAG(uname, flname) \
| ^~~~~~~~~~~~~
include/linux/hugetlb.h:531:1: note: in expansion of macro 'HPAGEFLAG'
531 | HPAGEFLAG(RestoreReserve, restore_reserve)
| ^~~~~~~~~
kernel/events/core.c: At top level:
kernel/events/core.c:6539:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
6539 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
| ^~~~~~~~~~~~~~~~~~~~~

vim +512 include/linux/hugetlb.h

488
489 /*
490 * Macros to create test, set and clear function definitions for
491 * hugetlb specific page flags.
492 */
493 #ifdef CONFIG_HUGETLB_PAGE
494 #define TESTHPAGEFLAG(uname, flname) \
495 static inline int HPage##uname(struct page *page) \
496 { BUILD_BUG_ON(sizeof_field(struct page, private) * \
497 BITS_PER_BYTE < __NR_HPAGEFLAGS); \
498 return test_bit(HPG_##flname, &(page->private)); }
499
500 #define SETHPAGEFLAG(uname, flname) \
501 static inline void SetHPage##uname(struct page *page) \
502 { set_bit(HPG_##flname, &(page->private)); }
503
504 #define CLEARHPAGEFLAG(uname, flname) \
505 static inline void ClearHPage##uname(struct page *page) \
506 { clear_bit(HPG_##flname, &(page->private)); }
507 #else
508 #define TESTHPAGEFLAG(uname, flname) \
509 static inline int HPage##uname(struct page *page) \
510 { BUILD_BUG_ON(sizeof_field(struct page, private) * \
511 BITS_PER_BYTE < __NR_HPAGEFLAGS); \
> 512 return 0 }
513

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 10838 bytes --]