Re: [PATCH] block: Fix an error handling in add_partition

Chaitanya Kulkarni
2021-01-16T08:19:36Z

On 1/15/21 11:34 PM, Dinghao Liu wrote:
> Once we have called device_initialize(), we should
> use put_device() to give up the reference on error,
> just like what we have done on failure of device_add().
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Please consider having following commit message, since above
commit message is looking odd from what we have in the tree :-

Once we have called device_initialize(), we should use put_device() to
give up the reference on error, just like what we have done on failure
of device_add().

Also have you tested this patch with the with generating appropriate error ?