From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: robh+dt@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, okukatla@codeaurora.org
Subject: Re: [PATCH 2/2] interconnect: qcom: Add SDX55 interconnect provider driver
Date: Wed, 20 Jan 2021 22:07:35 +0530 [thread overview]
Message-ID: <20210120163735.GC54606@thinkpad> (raw)
In-Reply-To: <cb0f56b6-a75c-51a8-d640-08896d459a68@linaro.org>
Hi Georgi,
On Wed, Jan 20, 2021 at 04:59:31PM +0200, Georgi Djakov wrote:
> Hi Mani,
>
> Thanks for the patch!
>
> On 1/20/21 10:06, Manivannan Sadhasivam wrote:
> > Add driver for the Qualcomm interconnect buses found in SDX55 based
> > platforms. The topology consists of several NoCs that are controlled by
> > a remote processor that collects the aggregated bandwidth for each
> > master-slave pairs.
> >
> > Based on SM8250 driver and generated from downstream dts.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > drivers/interconnect/qcom/Kconfig | 10 +
> > drivers/interconnect/qcom/Makefile | 2 +
> > drivers/interconnect/qcom/sdx55.c | 356 +++++++++++++++++++++++++++++
> > drivers/interconnect/qcom/sdx55.h | 70 ++++++
> > 4 files changed, 438 insertions(+)
> > create mode 100644 drivers/interconnect/qcom/sdx55.c
> > create mode 100644 drivers/interconnect/qcom/sdx55.h
> >
> > diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
> > index a8f93ba265f8..6df7e2161a0a 100644
> > --- a/drivers/interconnect/qcom/Kconfig
> > +++ b/drivers/interconnect/qcom/Kconfig
> > @@ -65,6 +65,16 @@ config INTERCONNECT_QCOM_SDM845
> > This is a driver for the Qualcomm Network-on-Chip on sdm845-based
> > platforms.
> > +config INTERCONNECT_QCOM_SDX55
> > + tristate "Qualcomm SDX55 interconnect driver"
> > + depends on INTERCONNECT_QCOM
> > + depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
>
> Why not use depends on INTERCONNECT_QCOM_RPMH_POSSIBLE?
>
I just followed the same pattern as other RPMh based drivers. And I don't get
what you are suggesting here! Can you please explain?
Thanks,
Mani
next prev parent reply other threads:[~2021-01-20 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 8:06 [PATCH 0/2] Add interconnect driver for SDX55 Manivannan Sadhasivam
2021-01-20 8:06 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SDX55 DT bindings Manivannan Sadhasivam
2021-01-20 8:06 ` [PATCH 2/2] interconnect: qcom: Add SDX55 interconnect provider driver Manivannan Sadhasivam
2021-01-20 14:59 ` Georgi Djakov
2021-01-20 16:37 ` Manivannan Sadhasivam [this message]
2021-01-20 17:37 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120163735.GC54606@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okukatla@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox