From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49628C433E0 for ; Wed, 20 Jan 2021 19:17:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC7D1233EB for ; Wed, 20 Jan 2021 19:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392437AbhATTRO (ORCPT ); Wed, 20 Jan 2021 14:17:14 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2386 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389703AbhATSwT (ORCPT ); Wed, 20 Jan 2021 13:52:19 -0500 Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DLZJW6Yxgz67XQp; Thu, 21 Jan 2021 02:47:23 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 20 Jan 2021 19:51:33 +0100 Received: from localhost (10.47.67.172) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 20 Jan 2021 18:51:32 +0000 Date: Wed, 20 Jan 2021 18:50:52 +0000 From: Jonathan Cameron To: Mike Looijmans CC: , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , , Subject: Re: [PATCH v6 1/2] dt-bindings: iio: accel: Add bmi088 accelerometer bindings Message-ID: <20210120185052.000064df@Huawei.com> In-Reply-To: <20210119124622.9490-1-mike.looijmans@topic.nl> References: <20210119124622.9490-1-mike.looijmans@topic.nl> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.67.172] X-ClientProxiedBy: lhreml717-chm.china.huawei.com (10.201.108.68) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jan 2021 13:46:21 +0100 Mike Looijmans wrote: > This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU, > the accelerometer part. > > Signed-off-by: Mike Looijmans > > --- > > Changes in v6: > I't been almost a year since the last commit, sorry... No problem. Happens to us all sometimes! One thing inline below. Thanks, Jonathan > Fixed the yaml errors > Add interrupt, vdd and vddio properties > > Changes in v5: > submit together with driver code as patch series > > Changes in v2: > convert to yaml format > > .../bindings/iio/accel/bosch,bmi088.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > new file mode 100644 > index 000000000000..459b9969fd12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/bosch,bmi088.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bosch BMI088 IMU accelerometer part > + > +maintainers: > + - Mike Looijmans > + > +description: | > + Acceleration part of the IMU sensor with an SPI interface > + Specifications about the sensor can be found at: > + https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf > + > +properties: > + compatible: > + enum: > + - bosch,bmi088_accel > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + > + vddio-supply: true > + > + interrupts: > + minItems: 1 > + maxItems: 2 > + description: | > + Type should be either IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_LEVEL_LOW. > + The first interrupt listed must be the one connected to the INT1 pin, the > + second must be the one connected to the INT2 pin. What if the board only has the INT2 pin connected? That's looks to be a valid hardware configuration. I'd suggest using interrupt-names to cover this. > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + bmi088_accel@1 { > + compatible = "bosch,bmi088_accel"; > + reg = <1>; > + spi-max-frequency = <10000000>; > + interrupt-parent = <&gpio6>; > + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +...