public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: <linux-iio@vger.kernel.org>
Cc: <jic23@kernel.org>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
	<linux-kernel@vger.kernel.org>, Dan Murphy <dmurphy@ti.com>
Subject: [PATCH 1/2] iio:adc:ti-ads124s08: Fix start stop conversion command
Date: Thu, 21 Jan 2021 13:14:30 -0600	[thread overview]
Message-ID: <20210121191431.12057-1-dmurphy@ti.com> (raw)

Fix start and stop conversion commands.  The proper command is not be
sent.

Fixes: ("e717f8c6dfec iio: adc: Add the TI ads124s08 ADC code")
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
 drivers/iio/adc/ti-ads124s08.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
index b4a128b19188..f05d4e0e1c9d 100644
--- a/drivers/iio/adc/ti-ads124s08.c
+++ b/drivers/iio/adc/ti-ads124s08.c
@@ -237,7 +237,7 @@ static int ads124s_read_raw(struct iio_dev *indio_dev,
 			goto out;
 		}
 
-		ret = ads124s_write_cmd(indio_dev, ADS124S08_START_CONV);
+		ret = ads124s_write_cmd(indio_dev, ADS124S08_CMD_START);
 		if (ret) {
 			dev_err(&priv->spi->dev, "Start conversions failed\n");
 			goto out;
@@ -251,7 +251,7 @@ static int ads124s_read_raw(struct iio_dev *indio_dev,
 
 		*val = ret;
 
-		ret = ads124s_write_cmd(indio_dev, ADS124S08_STOP_CONV);
+		ret = ads124s_write_cmd(indio_dev, ADS124S08_CMD_STOP);
 		if (ret) {
 			dev_err(&priv->spi->dev, "Stop conversions failed\n");
 			goto out;
-- 
2.29.2


             reply	other threads:[~2021-01-21 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 19:14 Dan Murphy [this message]
2021-01-21 19:14 ` [PATCH 2/2] iio:adc:ti-ads124s08: Fix packet read from the ADC Dan Murphy
2021-01-24 15:12   ` Jonathan Cameron
2021-01-28 14:07     ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121191431.12057-1-dmurphy@ti.com \
    --to=dmurphy@ti.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox