From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"jolsa@redhat.com" <jolsa@redhat.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"irogers@google.com" <irogers@google.com>,
"kjain@linux.ibm.com" <kjain@linux.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>
Subject: Re: [PATCH] perf metricgroup: Fix system PMU metrics
Date: Thu, 21 Jan 2021 17:31:36 -0300 [thread overview]
Message-ID: <20210121203136.GD356537@kernel.org> (raw)
In-Reply-To: <c3d8d635-33ab-8d7e-6efc-6a589aebeb52@huawei.com>
Em Wed, Jan 20, 2021 at 09:15:54AM +0000, John Garry escreveu:
> On 20/01/2021 05:15, Joakim Zhang wrote:
> > For this patch: Tested-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> > Hi John, Jolsa,
> > Is there any way to avoid breaking exist metric expressions? If not, it will always happened after metricgroup changes.
> They are not normally broken like that. Normally we test beforehand, but
> these cases were missed here by me. However if you were testing them
> previously, then it would be expected that you had tested them again for the
> final patchset which was merged.
> Anyway, we can look to add metric tests for these.
> @Arnaldo, I will send separate formal patch for this today.
Hi John, can you please take a look at my tmp.perf/urgent branch and see
if all is well, i.e. the versions of these patches are the ones that
should be merged and that all the patches discussed are there?
For your convenience:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf/urgent
Thanks,
- Arnaldo
next prev parent reply other threads:[~2021-01-21 20:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 10:04 [PATCH] perf metricgroup: Fix system PMU metrics John Garry
2021-01-19 10:56 ` Joakim Zhang
2021-01-19 11:04 ` John Garry
2021-01-19 11:13 ` Joakim Zhang
2021-01-19 12:02 ` John Garry
2021-01-19 15:47 ` John Garry
2021-01-19 17:33 ` John Garry
2021-01-20 5:15 ` Joakim Zhang
2021-01-20 9:15 ` John Garry
2021-01-20 10:19 ` Joakim Zhang
2021-01-21 20:31 ` Arnaldo Carvalho de Melo [this message]
2021-01-21 21:40 ` John Garry
2021-01-20 12:56 ` Jiri Olsa
2021-01-20 13:07 ` John Garry
2021-02-05 9:56 ` John Garry
2021-01-20 21:42 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121203136.GD356537@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox