From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Paul Cercueil <paul@crapouillou.net>,
Paul Burton <paulburton@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] MIPS: jazz: always allow little-endian builds
Date: Fri, 22 Jan 2021 14:05:55 +0100 [thread overview]
Message-ID: <20210122130555.GA10580@alpha.franken.de> (raw)
In-Reply-To: <20210122110307.934543-1-arnd@kernel.org>
On Fri, Jan 22, 2021 at 12:02:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The kernel test robot keeps reporting the same bug when it
> shows up in new files after random unrelated patches:
>
> In file included from arch/mips/include/uapi/asm/byteorder.h:13,
> from arch/mips/include/asm/bitops.h:20,
> from include/linux/bitops.h:26,
> from include/linux/kernel.h:12,
> from include/linux/clk.h:13,
> from drivers/base/regmap/regmap-mmio.c:7:
> include/linux/byteorder/big_endian.h:8:2: warning: #warning inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN [-Wcpp]
> 8 | #warning inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN
> | ^~~~~~~
> drivers/base/regmap/regmap-mmio.c: In function 'regmap_mmio_gen_context':
> >> drivers/base/regmap/regmap-mmio.c:274:2: error: duplicate case value
> 274 | case REGMAP_ENDIAN_NATIVE:
> | ^~~~
> drivers/base/regmap/regmap-mmio.c:246:2: note: previously used here
> 246 | case REGMAP_ENDIAN_NATIVE:
>
> The problem is that some randconfig builds end up on the MIPS jazz
> platform with neither CONFIG_CPU_BIG_ENDIAN nor CONFIG_CPU_LITTLE_ENDIAN
> because no specific machine is selected. As it turns out, all jazz
> machines support little-endian kernels, so this can simply be allowed
> globally.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> The configuration used by lkp here showed two other unrelated bugs,
> one of which I'm addressing in another patch. The one I'm not
> addressing is that 32-bit JAZZ with hugepages and 4K pages triggers
> BUILD_BUG_ON(IS_ENABLED(CONFIG_32BIT) && (_PFN_SHIFT > PAGE_SHIFT)).
> ---
> arch/mips/Kconfig | 1 +
> arch/mips/jazz/Kconfig | 3 ---
> 2 files changed, 1 insertion(+), 3 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-01-24 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 11:02 [PATCH 1/2] MIPS: jazz: always allow little-endian builds Arnd Bergmann
2021-01-22 11:02 ` [PATCH 2/2] MIPS: make kgdb depend on FPU support Arnd Bergmann
2021-01-22 13:06 ` Thomas Bogendoerfer
2021-02-08 17:03 ` Maciej W. Rozycki
2021-02-10 11:38 ` Daniel Thompson
2021-02-10 12:11 ` Maciej W. Rozycki
2021-02-10 12:29 ` Daniel Thompson
2021-02-10 14:15 ` Maciej W. Rozycki
2021-02-10 17:05 ` Daniel Thompson
2021-01-22 13:05 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122130555.GA10580@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox