From: Guenter Roeck <linux@roeck-us.net>
To: trix@redhat.com
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: it8712f_wdt: remove definition of DEBUG
Date: Sat, 23 Jan 2021 09:15:36 -0800 [thread overview]
Message-ID: <20210123171536.GA55320@roeck-us.net> (raw)
In-Reply-To: <20210115153237.131357-1-trix@redhat.com>
On Fri, Jan 15, 2021 at 07:32:37AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Defining DEBUG should only be done in development.
> So remove DEBUG.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/it8712f_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/it8712f_wdt.c b/drivers/watchdog/it8712f_wdt.c
> index 9b89d2f09568..3ce6a58bd81e 100644
> --- a/drivers/watchdog/it8712f_wdt.c
> +++ b/drivers/watchdog/it8712f_wdt.c
> @@ -31,7 +31,6 @@
> #include <linux/io.h>
> #include <linux/ioport.h>
>
> -#define DEBUG
> #define NAME "it8712f_wdt"
>
> MODULE_AUTHOR("Jorge Boncompte - DTI2 <jorge@dti2.net>");
prev parent reply other threads:[~2021-01-23 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 15:32 [PATCH] watchdog: it8712f_wdt: remove definition of DEBUG trix
2021-01-23 17:15 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123171536.GA55320@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=trix@redhat.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox