Re: [PATCH 2/3] dt-bindings: iio: Add cros ec proximity yaml doc

Stephen Boyd
2021-01-26T10:01:28Z

Quoting Rob Herring (2021-01-25 07:02:03)
> On Sun, Jan 24, 2021 at 05:27:56PM +0000, Jonathan Cameron wrote:
> > On Fri, 22 Jan 2021 14:54:42 -0800
> > Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > > Some cros ECs support a front proximity MKBP event via
> > > 'EC_MKBP_FRONT_PROXIMITY'. Add a DT binding to document this feature via
> > > a node that is a child of the main cros_ec device node. Devices that
> > > have this ability will describe this in firmware.
> > >
> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > Cc: Benson Leung <bleung@chromium.org>
> > > Cc: Guenter Roeck <groeck@chromium.org>
> > > Cc: Douglas Anderson <dianders@chromium.org>
> > > Cc: Gwendal Grignou <gwendal@chromium.org>
> > > Cc: <devicetree@vger.kernel.org>
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > > ---
> > > .../proximity/google,cros-ec-proximity.yaml | 37 +++++++++++++++++++
> > > 1 file changed, 37 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml b/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml
> > > new file mode 100644
> > > index 000000000000..c0a34bdfe4fd
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml
> > > @@ -0,0 +1,37 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +
> > > +$id: http://devicetree.org/schemas/iio/proximity/google,cros-ec-proximity.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: ChromeOS EC MKBP Proximity Sensor
> > > +
> > > +maintainers:
> > > + - Stephen Boyd <swboyd@chromium.org>
> > > + - Benson Leung <bleung@chromium.org>
> > > + - Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > > +
> > > +description: |
> > > + Google's ChromeOS EC sometimes has the ability to detect user proximity.
> > > + This is implemented on the EC as near/far logic and exposed to the OS
> > > + via an MKBP switch bit.
> > > +
> > > +properties:
> > > + compatible:
> > > + const: google,cros-ec-proximity
> > > +
> > > + label:
> > > + description: Name for proximity sensor
> > > +
> > > +required:
> > > + - compatible
> > > +
> > > +unevaluatedProperties: false
>
> additionalProperties: false
>
> > > +
> > > +examples:
> > > + - |
> > > + proximity {
> >
> > Can we at least have the example making it clear this is a child of the
> > cros_ec device?
>
> Move this to the core Cros EC binding. The core binding needs to define
> 'proximity' and reference this binding ($ref).

Will do.