Re: [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8910: Add imu/magnetometer

Konrad Dybcio
2021-01-24T15:08:20Z

> +&blsp_i2c3 {
> + status = "okay";
> +
> + imu@68 {
> + compatible = "bosch,bmi160";
> + reg = <0x68>;
> +
> + vdd-supply = <&pm8916_l17>;
> + vddio-supply = <&pm8916_l6>;
> +
> + mount-matrix = "0", "1", "0",
> + "-1", "0", "0",
> + "0", "0", "1";
> + };
> +
> + magnetometer@d {
> + compatible = "asahi-kasei,ak09911";
> + reg = <0x0d>;
> +
> + vdd-supply = <&pm8916_l17>;
> + vid-supply = <&pm8916_l6>;
> +
> + reset-gpios = <&msmgpio 111 GPIO_ACTIVE_LOW>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&mag_reset_default>;
> + };
> +};

Please sort I2C devices by their address.

> };
>
> + mag_reset_default: mag-reset-default {
> + pins = "gpio111";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-disable;
> + };
> +

Please add this after gpio110 to keep it sorted gpio-number-wise.

Konrad