From: Lee Jones <lee.jones@linaro.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: linux-kernel@vger.kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, Paul Walmsley <paul.walmsley@sifive.com>,
Pragnesh.patel@sifive.com, zong.li@sifive.com,
linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 06/20] clk: sifive: fu540-prci: Declare static const variable 'prci_clk_fu540' where it's used
Date: Mon, 25 Jan 2021 08:47:39 +0000 [thread overview]
Message-ID: <20210125084739.GW4903@dell> (raw)
In-Reply-To: <mhng-d13d3ca6-2ec1-4c56-a4a8-56faafe5569c@palmerdabbelt-glaptop>
On Fri, 22 Jan 2021, Palmer Dabbelt wrote:
> On Wed, 20 Jan 2021 01:30:26 PST (-0800), lee.jones@linaro.org wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/clk/sifive/fu540-prci.h:16:35: warning: ‘prci_clk_fu540’ defined but not used [-Wunused-const-variable=]
> > drivers/clk/sifive/fu540-prci.h:16:35: warning: ‘prci_clk_fu540’ defined but not used [-Wunused-const-variable=]
> >
> > Cc: Michael Turquette <mturquette@baylibre.com>
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Cc: Paul Walmsley <paul.walmsley@sifive.com>
> > Cc: Palmer Dabbelt <palmer@dabbelt.com>
> > Cc: Pragnesh Patel <Pragnesh.patel@sifive.com>
> > Cc: Zong Li <zong.li@sifive.com>
> > Cc: linux-clk@vger.kernel.org
> > Cc: linux-riscv@lists.infradead.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/clk/sifive/fu540-prci.h | 5 -----
> > drivers/clk/sifive/sifive-prci.c | 5 +++++
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/clk/sifive/fu540-prci.h b/drivers/clk/sifive/fu540-prci.h
> > index c8271efa7bdc7..c220677dc0108 100644
> > --- a/drivers/clk/sifive/fu540-prci.h
> > +++ b/drivers/clk/sifive/fu540-prci.h
> > @@ -13,9 +13,4 @@
> >
> > extern struct __prci_clock __prci_init_clocks_fu540[NUM_CLOCK_FU540];
> >
> > -static const struct prci_clk_desc prci_clk_fu540 = {
> > - .clks = __prci_init_clocks_fu540,
> > - .num_clks = ARRAY_SIZE(__prci_init_clocks_fu540),
> > -};
> > -
> > #endif /* __SIFIVE_CLK_FU540_PRCI_H */
> > diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
> > index c78b042750e21..1490b01ce6290 100644
> > --- a/drivers/clk/sifive/sifive-prci.c
> > +++ b/drivers/clk/sifive/sifive-prci.c
> > @@ -12,6 +12,11 @@
> > #include "fu540-prci.h"
> > #include "fu740-prci.h"
> >
> > +static const struct prci_clk_desc prci_clk_fu540 = {
> > + .clks = __prci_init_clocks_fu540,
> > + .num_clks = ARRAY_SIZE(__prci_init_clocks_fu540),
> > +};
> > +
> > /*
> > * Private functions
> > */
>
> This doesn't look like my sifive-prci.c, so I'm assuming it's against one of
> the clock trees and therefor should go in over there.
This patch is applied against -next.
> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
Thanks Palmer.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-01-25 9:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 9:30 [PATCH 00/20] Rid W=1 warnings from Clock Lee Jones
2021-01-20 9:30 ` [PATCH 01/20] clk: rockchip: clk: Demote non-conformant kernel-doc headers Lee Jones
2021-01-20 9:30 ` [PATCH 02/20] clk: rockchip: clk-cpu: Remove unused/undocumented struct members Lee Jones
2021-01-20 9:30 ` [PATCH 03/20] clk: rockchip: clk-pll: Demote kernel-doc abuses to standard comment blocks Lee Jones
2021-01-20 9:30 ` [PATCH 04/20] clk: rockchip: clk-half-divider: Demote non-conformant kernel-doc header Lee Jones
2021-01-20 9:30 ` [PATCH 05/20] clk: bcm: clk-iproc-pll: Demote kernel-doc abuse Lee Jones
2021-02-11 19:49 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 06/20] clk: sifive: fu540-prci: Declare static const variable 'prci_clk_fu540' where it's used Lee Jones
2021-01-23 4:07 ` Palmer Dabbelt
2021-01-25 8:47 ` Lee Jones [this message]
2021-02-11 19:49 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 07/20] clk: socfpga: clk-pll: Remove unused variable 'rc' Lee Jones
2021-01-21 4:11 ` Dinh Nguyen
2021-02-11 19:50 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 08/20] clk: socfpga: clk-pll-a10: Remove set but " Lee Jones
2021-01-21 4:11 ` Dinh Nguyen
2021-02-11 19:50 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 09/20] clk: mvebu: ap-cpu-clk: Demote non-conformant kernel-doc header Lee Jones
2021-02-11 19:50 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 10/20] clk: imx: clk-imx31: Remove unused static const table 'uart_clks' Lee Jones
2021-01-20 9:30 ` [PATCH 11/20] clk: st: clkgen-pll: Demote unpopulated kernel-doc header Lee Jones
2021-02-11 19:51 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 12/20] clk: st: clkgen-fsyn: Fix worthy struct documentation demote partially filled one Lee Jones
2021-02-11 19:51 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 13/20] clk: ti: clockdomain: Fix description for 'omap2_init_clk_clkdm's hw param Lee Jones
2021-01-20 11:27 ` Tero Kristo
2021-02-11 19:52 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 14/20] clk: sunxi: clk-sunxi: Demote a bunch of non-conformant kernel-doc headers Lee Jones
2021-01-20 9:30 ` [PATCH 15/20] clk: ti: dpll: Fix misnaming of '_register_dpll()'s 'user' parameter Lee Jones
2021-01-20 11:27 ` Tero Kristo
2021-02-11 19:52 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 16/20] clk: ti: gate: Fix possible doc-rot in 'omap36xx_gate_clk_enable_with_hsdiv_restore' Lee Jones
2021-01-20 11:28 ` Tero Kristo
2021-02-11 19:53 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 17/20] clk: sunxi: clk-a10-ve: Demote obvious kernel-doc abuse Lee Jones
2021-01-20 9:30 ` [PATCH 18/20] clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header Lee Jones
2021-01-20 9:58 ` Maxime Ripard
2021-01-20 9:30 ` [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block Lee Jones
2021-01-21 8:31 ` Linus Walleij
2021-02-11 19:53 ` Stephen Boyd
2021-01-20 9:30 ` [PATCH 20/20] clk: zynq: clkc: Remove various instances of an unused variable 'clk' Lee Jones
2021-02-11 19:53 ` Stephen Boyd
2021-01-25 23:56 ` (subset) [PATCH 00/20] Rid W=1 warnings from Clock Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125084739.GW4903@dell \
--to=lee.jones@linaro.org \
--cc=Pragnesh.patel@sifive.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sboyd@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox