Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

Russell King - ARM Linux admin
2021-01-09T15:47:23Z

On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wrote:
> On Wed, Jan 06, 2021 at 04:37:48PM +0100, Pali Rohár wrote:
> > From: Russell King <rmk+kernel@armlinux.org.uk>
> >
> > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both
> > SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits in their EEPROM.
> >
> > Such combination of bits is meaningless so assume that LOS signal is not
> > implemented.
> >
> > This patch fixes link carrier for GPON SFP module Ubiquiti U-Fiber Instant.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > Signed-off-by: Pali Rohár <pali@kernel.org>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

I'd like to send this patch irrespective of discussion on the other
patches - I already have it committed in my repository with a different
description, but the patch content is the same.

Are you happy if I transfer Andrew's r-b tag, and convert yours to an
acked-by before I send it?

I'd also like to add a patch that allows 2.5G if no other modes are
found, but the bitrate specified by the module allows 2.5G speed - much
like we do for 1G speeds.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!