Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

Andrew Lunn
2021-01-07T16:55:13Z

On Wed, Jan 06, 2021 at 04:37:48PM +0100, Pali Rohár wrote:
> From: Russell King <rmk+kernel@armlinux.org.uk>
>
> Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both
> SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits in their EEPROM.
>
> Such combination of bits is meaningless so assume that LOS signal is not
> implemented.
>
> This patch fixes link carrier for GPON SFP module Ubiquiti U-Fiber Instant.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Andrew