Re: [PATCH 4.19 12/58] dm integrity: select CRYPTO_SKCIPHER

Anthony Iliopoulos
2021-01-25T19:49:36Z

On Mon, Jan 25, 2021 at 07:58:29PM +0100, Pavel Machek wrote:
> Hi!
>
> > From: Anthony Iliopoulos <ailiop@suse.com>
> >
> > [ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ]
> >
> > The integrity target relies on skcipher for encryption/decryption, but
> > certain kernel configurations may not enable CRYPTO_SKCIPHER, leading to
> > compilation errors due to unresolved symbols. Explicitly select
> > CRYPTO_SKCIPHER for DM_INTEGRITY, since it is unconditionally dependent
> > on it.
>
> There is no such config option in 4.19. This patch is not suitable
> here.
>
> grep -r CRYPTO_SKCIPHER .
> ./include/crypto/skcipher.h:#ifndef _CRYPTO_SKCIPHER_H
> ./include/crypto/skcipher.h:#define _CRYPTO_SKCIPHER_H
> ./include/crypto/skcipher.h:#endif /* _CRYPTO_SKCIPHER_H */

This is due to commit b95bba5d0114 ("crypto: skcipher - rename the
crypto_blkcipher module and kconfig option"), which was applied in
v5.5-rc1. As already pointed out in [1], if this is to be backported to
any earlier releases then SKCIPHER needs to be changed to BLKCIPHER.

Best regards,
Anthony

[1] https://lore.kernel.org/lkml/YAfD81Jw%2F0NU0eWN@sol.localdomain/#t