Re: [PATCH 2/5] kernel/dma: remove unnecessary unmap_kernel_range

Nicholas Piggin
2021-01-27T23:47:35Z

Excerpts from Christoph Hellwig's message of January 27, 2021 5:10 pm:
> On Tue, Jan 26, 2021 at 05:08:46PM -0500, Konrad Rzeszutek Wilk wrote:
>> On Tue, Jan 26, 2021 at 02:54:01PM +1000, Nicholas Piggin wrote:
>> > vunmap will remove ptes.
>>
>> Should there be some ASSERT after the vunmap to make sure that is the
>> case?
>
> Not really. removing the PTEs is the whole point of vunmap. Everything
> else is just house keeping.

Agree. I did double check this and wrote a quick test to check ptes were
there before the vunmap and cleared after, just to make sure I didn't
make a silly mistake with the patch. But in general drivers should be
able to trust code behind the API call will do the right thing. Such
assertions should go in the vunmap() implementation as appropriate.

Thanks,
Nick