Re: [PATCH 03/12] docs: path-lookup: update path_mountpoint() part

NeilBrown
2021-01-28T03:29:56Z

[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]

On Tue, Jan 26 2021, Fox Chen wrote:

> path_mountpoint() doesn't exist anymore. Have been folded
> into path_lookup_at when flag is set with LOOKUP_MOUNTPOINT.
> check out commit:161aff1d93abf0e5b5e9dbca88928998c155f677
>
> Signed-off-by: Fox Chen <foxhlchen@gmail.com>
> ---
> Documentation/filesystems/path-lookup.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/path-lookup.rst b/Documentation/filesystems/path-lookup.rst
> index 2ad96e1e3c49..4e77c8520fa9 100644
> --- a/Documentation/filesystems/path-lookup.rst
> +++ b/Documentation/filesystems/path-lookup.rst
> @@ -492,7 +492,8 @@ not try to revalidate the mounted filesystem. It effectively
> contains, through a call to ``mountpoint_last()``, an alternate
> implementation of ``lookup_slow()`` which skips that step. This is
> important when unmounting a filesystem that is inaccessible, such as
> -one provided by a dead NFS server.
> +one provided by a dead NFS server. In the current kernel, path_mountpoint
> +has been merged into ``path_lookup_at()`` with a new flag LOOKUP_MOUNTPOINT.

You've taken a very different approach here. Rather than re-telling the
story you have added a note (like a foot-note) that the details have
changed, withouy trying to re-weave the story. The is easier to get
right, but doesn't produce as nice a result.

Maybe this is a good approach, it depends on how much effort you are
willing/able to spend on the task.

IF you do stick with this approach: it is "path_lookupat", not
"path_lookup_at".

NeilBrown

>
> Finally ``path_openat()`` is used for the ``open()`` system call; it
> contains, in support functions starting with "``do_last()``", all the
> --
> 2.30.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]