Re: [PATCH 00/12] docs: path-lookup: Update pathlookup docs

Fox Chen
2021-01-29T01:30:38Z

On Thu, Jan 28, 2021 at 11:58 AM NeilBrown <neilb@suse.de> wrote:
>
> On Tue, Jan 26 2021, Fox Chen wrote:
>
> > The Path lookup is a very complex subject in VFS. The path-lookup
> > document provides a very detailed guidance to help people understand
> > how path lookup works in the kernel.This document was originally
> > written based on three lwn articles five years ago. As times goes by,
> > some of the content was outdated. This patchset is intended to update
> > the document to make it more relevant to current codebase.
> >
> >
> > Fox Chen (12):
> > docs: path-lookup: update follow_managed() part
> > docs: path-lookup: update path_to_nameidata() parth
> > docs: path-lookup: update path_mountpoint() part
> > docs: path-lookup: update do_last() part
> > docs: path-lookup: remove filename_mountpoint
> > docs: path-lookup: Add macro name to symlink limit description
> > docs: path-lookup: i_op->follow_link replaced with i_op->get_link
> > docs: path-lookup: update i_op->put_link and cookie description
> > docs: path-lookup: no get_link()
> > docs: path-lookup: update WALK_GET, WALK_PUT desc
> > docs: path-lookup: update get_link() ->follow_link description
> > docs: path-lookup: update symlink description
> >
>
> Thanks for doing this. I've responded individually to several of the
> patches. As you can see from my comments, there is often more to it
> than just changing function names. In some places you have capture the
> more general nature of the change fairly well. In other places the
> result is incoherent or confusion.
> Making small updates to this sort of documentation is not easy. You
> need to step have and see the "big picture", to overall story-arc.
> Sometimes you can fit changes into that arc, sometimes you might need to
> restructure or re-tell the story.
>
> This is part of why I haven't put much effort into the document -
> re-telling a story can be a lot of work.
>

Thanks for reviewing my patchset. Yeah, sometimes it's difficult to
fit in the context and match the writing style. Most part of the
article is still valid, adding annotations may be better than rewrite.

Let me revise it and send in the v2, though It may take a while.

thanks,
fox

> NeilBrown