From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F14EDC4332D for ; Tue, 26 Jan 2021 11:39:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5E3A23119 for ; Tue, 26 Jan 2021 11:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405386AbhAZLjy (ORCPT ); Tue, 26 Jan 2021 06:39:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404228AbhAZKmr (ORCPT ); Tue, 26 Jan 2021 05:42:47 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DC04C061573; Tue, 26 Jan 2021 02:42:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hr2jNE3FMs8l6Tfz1HIwxXewKUv5fGgvc4zfcKNrlaA=; b=WEjIlqkhoVgDHdg9Ci9uC20sx Aq1xjvy8PWLCLqhxTv70yicvH+0kQAObTd0/f5e+0xFweCfTW1eThsfgw69Wqj+VBXTZsNd2j8hoT fSgHaIniEvMfRZKBIcSRlaUv8TJHVSKuBViU6pScN25mk7DhylHilRVZZImp/bOqeBszQ/rJ9lwbr OrhK0yRPaGHjC7MX78I7otVrF+x9Z4vD6alNVN3KqU0ashV2KonhjSEGtgYnfMcKLVOMShZEk2SHL xYpxuF9hV0A6H/lMUHaQFeljsooO23dqnz1ZUtyOVWNu6AgqYX7L9ABu+UlenVS2SEatkKZEJnBE6 o5pnSNlug==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52916) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4LnI-0004Hj-Tt; Tue, 26 Jan 2021 10:41:57 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l4LnH-0003jP-6L; Tue, 26 Jan 2021 10:41:55 +0000 Date: Tue, 26 Jan 2021 10:41:55 +0000 From: Russell King - ARM Linux admin To: Geert Uytterhoeven Cc: Wolfram Sang , Linux ARM , Linux-Renesas , Thomas Gleixner , Marc Zyngier , Linux Kernel Mailing List Subject: Re: [PATCH] arm: smp: remove unused variable Message-ID: <20210126104155.GF1551@shell.armlinux.org.uk> References: <20201228120147.59387-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 11:04:47AM +0100, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Mon, Dec 28, 2020 at 1:03 PM Wolfram Sang > wrote: > > Not used anymore after refactoring: > > > > arch/arm/kernel/smp.c: In function ‘show_ipi_list’: > > arch/arm/kernel/smp.c:543:16: warning: variable ‘irq’ set but not used [-Wunused-but-set-variable] > > 543 | unsigned int irq; > > > > Fixes: 88c637748e31 ("ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()") > > Signed-off-by: Wolfram Sang > > Cc: Thomas Gleixner > > Cc: Marc Zyngier > > Known issue since Dec 15, and still not fixed... > > Reviewed-by: Geert Uytterhoeven Those who cause breakage really should be the ones to look at patches that fix their breakage. The way patches get applied is if they end up in my patch system... if they don't make it there, they don't get applied. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!