The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Gow <davidgow@google.com>
To: Pawel Czarnecki <pczarnecki@internships.antmicro.com>,
	Stafford Horne <shorne@gmail.com>,
	Mateusz Holenko <mholenko@antmicro.com>
Cc: David Gow <davidgow@google.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] soc: litex: Properly depend on HAS_IOMEM
Date: Tue, 26 Jan 2021 19:36:04 -0800	[thread overview]
Message-ID: <20210127033603.1519127-1-davidgow@google.com> (raw)

The LiteX SOC controller driver makes use of IOMEM functions like
devm_platform_ioremap_resource(), which are only available if
CONFIG_HAS_IOMEM is defined.

This causes the driver not to be enable under make ARCH=um allyesconfig,
even though it won't build.

By adding a dependency on HAS_IOMEM, the driver will not be enabled on
architectures which don't support it.

Fixes: 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver")
Signed-off-by: David Gow <davidgow@google.com>
---
 drivers/soc/litex/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/litex/Kconfig b/drivers/soc/litex/Kconfig
index 7c6b009b6f6c..7a7c38282e11 100644
--- a/drivers/soc/litex/Kconfig
+++ b/drivers/soc/litex/Kconfig
@@ -8,6 +8,7 @@ config LITEX
 config LITEX_SOC_CONTROLLER
 	tristate "Enable LiteX SoC Controller driver"
 	depends on OF || COMPILE_TEST
+	depends on HAS_IOMEM
 	select LITEX
 	help
 	  This option enables the SoC Controller Driver which verifies
-- 
2.30.0.280.ga3ce27912f-goog


             reply	other threads:[~2021-01-27  4:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  3:36 David Gow [this message]
2021-01-27 12:27 ` [PATCH] soc: litex: Properly depend on HAS_IOMEM Stafford Horne
2021-01-27 16:49   ` David Gow
2021-01-27 23:17     ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210127033603.1519127-1-davidgow@google.com \
    --to=davidgow@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mholenko@antmicro.com \
    --cc=pczarnecki@internships.antmicro.com \
    --cc=shorne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox