From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 065B2C433E0 for ; Wed, 27 Jan 2021 11:39:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BB1D2076D for ; Wed, 27 Jan 2021 11:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236928AbhA0Lia (ORCPT ); Wed, 27 Jan 2021 06:38:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:48080 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234365AbhA0Lf0 (ORCPT ); Wed, 27 Jan 2021 06:35:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BD444AC9B; Wed, 27 Jan 2021 11:34:43 +0000 (UTC) Date: Wed, 27 Jan 2021 12:34:41 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/vmemmap: Handle unpopulated sub-pmd ranges Message-ID: <20210127113436.GA28551@linux> References: <20210127112315.28297-1-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021 at 12:29:27PM +0100, David Hildenbrand wrote: > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > > index b5a3fa4033d3..9b6d45ea353b 100644 > > --- a/arch/x86/mm/init_64.c > > +++ b/arch/x86/mm/init_64.c > > @@ -873,6 +873,71 @@ int arch_add_memory(int nid, u64 start, u64 size, > > #define PAGE_INUSE 0xFD > > Note that I called it "PAGE_UNUSED", using "PAGE_INUSE" might make it a > little harder to digest. Yeah, I wanted to recycle the PAGE_INUSE macro for x86, but on a second though we might just call it PAGE_UNUSE as it gives a better perspective. Let us see if there are other pushbacks/reviews, and if not, I shall re-submit with that addressed. Thanks -- Oscar Salvador SUSE L3