public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] arm64: dts: qcom: Add basic devicetree support for SM8350 SoC
Date: Wed, 27 Jan 2021 21:03:07 +0530	[thread overview]
Message-ID: <20210127153307.GC2771@vkoul-mobl> (raw)
In-Reply-To: <194d2ebe26a9420f842c97738adb0443@codeaurora.org>

Hi Sai,

On 27-01-21, 18:37, Sai Prakash Ranjan wrote:
> Hi Vinod,
> 
> On 2021-01-27 18:00, Vinod Koul wrote:

> > +	timer {
> > +		compatible = "arm,armv8-timer";
> > +		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) |
> > IRQ_TYPE_LEVEL_LOW)>,
> > +			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> > +			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> > +			     <GIC_PPI 12 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
> 
> The last interrupt should be hypervisor physical interrupt(10) not 12(hyp
> virtual).
> It works currently with android bootloaders because the host linux kernel
> will run
> at EL1 and will use EL1 physical timer interrupt(14), but if we ever have
> the host
> kernel run in EL2(for example, chrome) then we will not receive any timer
> interrupts.

I got these values from downstream and used them as is. I will update
and also check documentation. Thanks for pointing out

-- 
~Vinod

  reply	other threads:[~2021-01-27 15:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 12:30 [PATCH v2 0/6] Add binding and dts for Qualcomm SM8350 SoC Vinod Koul
2021-01-27 12:30 ` [PATCH v2 1/6] dt-bindings: arm: qcom: Document SM8350 SoC and boards Vinod Koul
2021-01-28 16:10   ` Bjorn Andersson
2021-01-27 12:30 ` [PATCH v2 2/6] soc: qcom: aoss: Add SM8350 compatible Vinod Koul
2021-01-27 12:30 ` [PATCH v2 3/6] dt-bindings: arm: cpus: Add kryo685 compatible Vinod Koul
2021-01-27 12:30 ` [PATCH v2 4/6] dt-bindings: firmware: scm: Add SM8250 and SM8350 compatible Vinod Koul
2021-01-27 12:30 ` [PATCH v2 5/6] arm64: dts: qcom: Add basic devicetree support for SM8350 SoC Vinod Koul
2021-01-27 13:07   ` Sai Prakash Ranjan
2021-01-27 15:33     ` Vinod Koul [this message]
2021-01-28  7:31       ` Sai Prakash Ranjan
2021-01-27 12:30 ` [PATCH v2 6/6] arm64: dts: qcom: Add basic devicetree support for SM8350-MTP board Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210127153307.GC2771@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox