From: Christoph Hellwig <hch@infradead.org>
To: Ray Chi <raychi@google.com>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kyletso@google.com
Subject: Re: [PATCH] usb: dwc3: add EXPORT_SYMBOL_GPL for role init functions
Date: Wed, 27 Jan 2021 18:08:44 +0000 [thread overview]
Message-ID: <20210127180844.GA1747134@infradead.org> (raw)
In-Reply-To: <20210126094913.180945-1-raychi@google.com>
On Tue, Jan 26, 2021 at 05:49:13PM +0800, Ray Chi wrote:
> Currently, role init functions are used in dwc3 driver but
> can't be called from kernel modules.
> dwc3_host_init
> dwc3_host_exit
> dwc3_gadget_init
> dwc3_gadget_exit
> dwc3_event_buffers_setup
> dwc3_event_buffers_cleanup
>
> If other kernel modules want to use these functions, it needs
> EXPORT_SYMBOL_GPL() to get compile pass.
What "other kernel modules" would want to use it an why?
Please specify that in your patch, and only resend it togethe with the
patches actually adding/modifying those modules.
prev parent reply other threads:[~2021-01-27 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 9:49 [PATCH] usb: dwc3: add EXPORT_SYMBOL_GPL for role init functions Ray Chi
2021-01-26 10:01 ` Greg KH
2021-01-26 12:14 ` Ray Chi
2021-01-26 12:20 ` Greg KH
2021-01-27 18:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127180844.GA1747134@infradead.org \
--to=hch@infradead.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=raychi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox