Re: [PATCH v10] staging: fbtft: add tearing signal detect

Greg KH
2021-01-27T14:16:39Z

On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote:
> On Wed, 27 Jan 2021 14:51:55 +0100
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote:
> > > From: zhangxuezhi <zhangxuezhi1@yulong.com>
> > >
> > > For st7789v ic,when we need continuous full screen refresh, it is
> > > best to wait for the TE signal arrive to avoid screen tearing
> > >
> > > Signed-off-by: zhangxuezhi <zhangxuezhi1@yulong.com>
> >
> > Please slow down and wait at least a day between patch submissions,
> > there is no rush here.
> >
> > And also, ALWAYS run scripts/checkpatch.pl on your submissions, so
> > that you don't have a maintainer asking you about basic problems,
> > like are in this current patch :(
> >
> > thanks,
> >
> > greg k-h
>
> hi,
> This is my first patch contribution to Linux, so some of the rules
> are not very clear .In addition, I can confirm that before sending
> patch, I check it with checkPatch.py every time.Thank you very much for
> your help

Please read Documentation/SubmittingPatches which has a link to the
checklist and other documentation you should read.

And I doubt you are running checkpatch on your submission, as there is
obvious coding style issues in it. If so, please provide the output as
it must be broken :(

thanks,

greg k-h