Re: [RFC PATCH 27/34] xfs: use bio_new in xfs_buf_ioapply_map

Darrick J. Wong
2021-01-28T17:25:33Z

On Wed, Jan 27, 2021 at 11:11:26PM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
> fs/xfs/xfs_buf.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index f8400bbd6473..3ff6235e4f94 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -1507,12 +1507,10 @@ xfs_buf_ioapply_map(
> atomic_inc(&bp->b_io_remaining);
> nr_pages = min(total_nr_pages, BIO_MAX_PAGES);
>
> - bio = bio_alloc(GFP_NOIO, nr_pages);
> - bio_set_dev(bio, bp->b_target->bt_bdev);
> - bio->bi_iter.bi_sector = sector;
> + bio = bio_new(bp->b_target->bt_bdev, sector, op, 0, nr_pages,
> + GFP_NOIO);
> bio->bi_end_io = xfs_buf_bio_end_io;
> bio->bi_private = bp;
> - bio->bi_opf = op;
>
> for (; size && nr_pages; nr_pages--, page_index++) {
> int rbytes, nbytes = PAGE_SIZE - offset;
> --
> 2.22.1
>