From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B1EC433DB for ; Fri, 29 Jan 2021 20:24:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA28364E05 for ; Fri, 29 Jan 2021 20:24:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233354AbhA2UYE (ORCPT ); Fri, 29 Jan 2021 15:24:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233236AbhA2UWS (ORCPT ); Fri, 29 Jan 2021 15:22:18 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46C5EC0617AB for ; Fri, 29 Jan 2021 12:20:31 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id p72so10612022iod.12 for ; Fri, 29 Jan 2021 12:20:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IyvOnmoZSqo2WxAcwPn8wTudNnGv17LW2Bgf4MzbHMg=; b=VQH3LBiTtAbVKsZ7bIPXv7N8Y56z2hGZVXASfmr8S5wK+/kuidN/tbI9eHA0E0zRtb s8EFwpujww5HWIcvaZchgGw+NwsCiBoMZZZjGizwuiVgyydyKupHLHqtPQaA7jYopSIC tHAuzDpHpxuwC1YpexvhBx8xxLgcIwp0IBIZITDnCa9cECdBL8D7yd7NwyEs60t5jYSi sBpnZjy5o7qtwEJjMH+KamWH8hw3yxzAF8T5BU5SKooTY1AlL7t8rOB1L0bc2PrVcG+4 EUV8MHriOpg2bVjwT5y4KKeYM7Qrnsgd7l7G5kelkwfLlzHtxx3xTqm4vf+yfaBPtm5K aEWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IyvOnmoZSqo2WxAcwPn8wTudNnGv17LW2Bgf4MzbHMg=; b=mJ8/8j0jqJBtVc3fFn+ULuYTBlmMvlSniu1pJ0wpz023a+582RFqTNmogbspsC6/S+ TiN7yCHauxH8QeYAuLcp4Zf1yLZz+AXkeOsUTsUL4nUhzXQOJwGr3QaoYSRdzN6JrWM3 aUGMXPX26wdljufjMZYt6Jj/ZNJnb0+UCVX3qkp90Yxt203b3sJjzO7z6sQy0m4S8M81 ho9iUFJjSH9iGMBaixcri4retbfWdkYnqHstpk06Zoe4fqTutJfXk9E4obyP1Zblv0wY rdU5bVJFGRm7KM+buGarDMTU8X5Pfq+UlvlY+oXjQ1ALbGpH0hPR2tTWR1Zn8rWeY548 sZew== X-Gm-Message-State: AOAM531yMvFteACNDuD6VB+WBzVe2RzNzd0as4hMBCYjcFlbW5W5LD+w v6jjN+YA45w/SqH8/b/n9J51kA== X-Google-Smtp-Source: ABdhPJzEd8JDEqy83Slf7ZqMcHQce5+cqynUYKeETnbzf96EYBiC8FmnG07NRpkjafnXrMjZOsB+sQ== X-Received: by 2002:a5d:8ac5:: with SMTP id e5mr4770819iot.33.1611951630792; Fri, 29 Jan 2021 12:20:30 -0800 (PST) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id h23sm4645738ila.15.2021.01.29.12.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 12:20:30 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: elder@kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 7/9] net: ipa: don't disable IEOB interrupt during suspend Date: Fri, 29 Jan 2021 14:20:17 -0600 Message-Id: <20210129202019.2099259-8-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210129202019.2099259-1-elder@linaro.org> References: <20210129202019.2099259-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No completion interrupts will occur while an endpoint is suspended, or when a channel has been stopped for suspend. So there's no need to disable the interrupt during suspend and re-enable it when resuming. We'll enable the interrupt when we first start the channel, and disable it again only when it's "really" stopped. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 70647e8450845..74d1dd04ad6e9 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -959,30 +959,16 @@ void gsi_channel_reset(struct gsi *gsi, u32 channel_id, bool doorbell) int gsi_channel_suspend(struct gsi *gsi, u32 channel_id, bool stop) { struct gsi_channel *channel = &gsi->channel[channel_id]; - int ret; - /* No completions when suspended; disable interrupt if successful */ - ret = __gsi_channel_stop(channel, stop); - if (!ret) - gsi_irq_ieob_disable_one(gsi, channel->evt_ring_id); - - return ret; + return __gsi_channel_stop(channel, stop); } /* Resume a suspended channel (starting will be requested if STOPPED) */ int gsi_channel_resume(struct gsi *gsi, u32 channel_id, bool start) { struct gsi_channel *channel = &gsi->channel[channel_id]; - int ret; - /* Re-enable the completion interrupt */ - gsi_irq_ieob_enable_one(gsi, channel->evt_ring_id); - - ret = __gsi_channel_start(channel, start); - if (ret) - gsi_irq_ieob_disable_one(gsi, channel->evt_ring_id); - - return ret; + return __gsi_channel_start(channel, start); } /** -- 2.27.0