Re: [PATCH v14 02/11] KVM: x86/pmu: Set up IA32_PERF_CAPABILITIES if PDCM bit is available

Paolo Bonzini
2021-02-02T11:50:10Z

On 01/02/21 06:10, Like Xu wrote:
>
> - if (guest_cpuid_has(vcpu, X86_FEATURE_PDCM))
> - vcpu->arch.perf_capabilities = vmx_get_perf_capabilities();

Why remove this "if"?

> pmu->nr_arch_gp_counters = min_t(int, eax.split.num_counters, > x86_pmu.num_counters_gp);
> @@ -405,6 +402,8 @@ static void intel_pmu_init(struct kvm_vcpu *vcpu)
> pmu->fixed_counters[i].idx = i + INTEL_PMC_IDX_FIXED;
> pmu->fixed_counters[i].current_config = 0;
> }
> +
> + vcpu->arch.perf_capabilities = 0;

Paolo