From: Iskren Chernev <iskren.chernev@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Iskren Chernev <iskren.chernev@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Andrei Ziureaev <andrei.ziureaev@arm.com>,
Cristian Ciocaltea <cristian.ciocaltea@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] dt-bindings: Use portable sort for version cmp
Date: Mon, 1 Feb 2021 18:58:28 +0200 [thread overview]
Message-ID: <20210201165829.58656-1-iskren.chernev@gmail.com> (raw)
sort -C is like sort -c >/dev/null but less portable. It fails on
busybox sort (i.e alpine linux).
Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
Fixes: ea5b8b5eb004 ("dt-bindings: Add a minimum version check for dtschema")
---
Documentation/devicetree/bindings/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index 90fcad98984d..780e5618ec0a 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -10,7 +10,7 @@ DT_SCHEMA_MIN_VERSION = 2020.8.1
PHONY += check_dtschema_version
check_dtschema_version:
@{ echo $(DT_SCHEMA_MIN_VERSION); \
- $(DT_DOC_CHECKER) --version 2>/dev/null || echo 0; } | sort -VC || \
+ $(DT_DOC_CHECKER) --version 2>/dev/null || echo 0; } | sort -Vc >/dev/null || \
{ echo "ERROR: dtschema minimum version is v$(DT_SCHEMA_MIN_VERSION)" >&2; false; }
quiet_cmd_extract_ex = DTEX $@
base-commit: fd821bf0ed9a7db09d2e007df697f4d9ecfda99a
prerequisite-patch-id: c90e3d48df0672dab84da1b294374598bfc45db8
prerequisite-patch-id: f0b48cda55170cf82855daa6f7b4edfdba83d90c
prerequisite-patch-id: 48482c0c3e2797459e311f73db1828f2531bd11c
prerequisite-patch-id: 5512fd0c8367c8c8a2ace8003b533057422e1437
prerequisite-patch-id: 1635c0e78c99506fd2710f54be4e5fc5980712a6
prerequisite-patch-id: e80dacf2da55197be027f297617868832ddabfc9
prerequisite-patch-id: bd3efb4ced6ceb2c6a50dcd8527ea4d6d19baf5d
--
2.30.0
next reply other threads:[~2021-02-01 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 16:58 Iskren Chernev [this message]
2021-02-09 20:57 ` [PATCH] dt-bindings: Use portable sort for version cmp Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201165829.58656-1-iskren.chernev@gmail.com \
--to=iskren.chernev@gmail.com \
--cc=andrei.ziureaev@arm.com \
--cc=cristian.ciocaltea@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox