From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28FFDC433E6 for ; Tue, 2 Feb 2021 08:53:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9A4C64F58 for ; Tue, 2 Feb 2021 08:53:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232672AbhBBIx5 (ORCPT ); Tue, 2 Feb 2021 03:53:57 -0500 Received: from mga05.intel.com ([192.55.52.43]:7656 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbhBBIxx (ORCPT ); Tue, 2 Feb 2021 03:53:53 -0500 IronPort-SDR: yoEb/BDw6S5i2WY3kg5rvk5sFMQbg+hruwTKdg2HtSNYXu66eSwzGV2Igq0lB37QrbG5jNYWCC iPRdkIcilFAQ== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="265653130" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="265653130" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 00:52:06 -0800 IronPort-SDR: +22FgflFJPsyFYdAlwZDDYTdCn+5fgEnwlPtNMH/+p0/XiUCDpYw3jE8itXqjD9el5dXBkCG6l SpeBKsdJj8LA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="479489771" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 02 Feb 2021 00:52:04 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 02 Feb 2021 10:52:03 +0200 Date: Tue, 2 Feb 2021 10:52:03 +0200 From: Heikki Krogerus To: Badhri Jagan Sridharan Cc: Guenter Roeck , Greg Kroah-Hartman , Kyle Tso , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] usb: typec: tcpci_maxim: Enable data path when partner is USB Comm capable Message-ID: <20210202085203.GG1433721@kuha.fi.intel.com> References: <20210202003101.221145-1-badhri@google.com> <20210202003101.221145-3-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202003101.221145-3-badhri@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 04:31:01PM -0800, Badhri Jagan Sridharan wrote: > Configure USB switches when partner is USB Communication capable. > The is enabled USB data communication over D+/D- pins. > > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/tcpm/tcpci_maxim.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c > index f1674a611033..041a1c393594 100644 > --- a/drivers/usb/typec/tcpm/tcpci_maxim.c > +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c > @@ -19,6 +19,9 @@ > #define PD_ACTIVITY_TIMEOUT_MS 10000 > > #define TCPC_VENDOR_ALERT 0x80 > +#define TCPC_VENDOR_USBSW_CTRL 0x93 > +#define TCPC_VENDOR_USBSW_CTRL_ENABLE_USB_DATA 0x9 > +#define TCPC_VENDOR_USBSW_CTRL_DISABLE_USB_DATA 0 > > #define TCPC_RECEIVE_BUFFER_COUNT_OFFSET 0 > #define TCPC_RECEIVE_BUFFER_FRAME_TYPE_OFFSET 1 > @@ -274,6 +277,21 @@ static void process_tx(struct max_tcpci_chip *chip, u16 status) > max_tcpci_init_regs(chip); > } > > +/* Enable USB switches when partner is USB communications capable */ > +static void max_tcpci_set_partner_usb_comm_capable(struct tcpci *tcpci, struct tcpci_data *data, > + bool capable) > +{ > + struct max_tcpci_chip *chip = tdata_to_max_tcpci(data); > + int ret; > + > + ret = max_tcpci_write8(chip, TCPC_VENDOR_USBSW_CTRL, capable ? > + TCPC_VENDOR_USBSW_CTRL_ENABLE_USB_DATA : > + TCPC_VENDOR_USBSW_CTRL_DISABLE_USB_DATA); > + > + if (ret < 0) > + dev_err(chip->dev, "Failed to enable USB switches"); > +} > + > static irqreturn_t _max_tcpci_irq(struct max_tcpci_chip *chip, u16 status) > { > u16 mask; > @@ -453,6 +471,7 @@ static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_id > chip->data.frs_sourcing_vbus = max_tcpci_frs_sourcing_vbus; > chip->data.auto_discharge_disconnect = true; > chip->data.vbus_vsafe0v = true; > + chip->data.set_partner_usb_comm_capable = max_tcpci_set_partner_usb_comm_capable; > > max_tcpci_init_regs(chip); > chip->tcpci = tcpci_register_port(chip->dev, &chip->data); > -- > 2.30.0.365.g02bc693789-goog thanks, -- heikki