From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A0AC433E0 for ; Tue, 2 Feb 2021 01:53:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 655B164EBD for ; Tue, 2 Feb 2021 01:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbhBBBxf (ORCPT ); Mon, 1 Feb 2021 20:53:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbhBBBxb (ORCPT ); Mon, 1 Feb 2021 20:53:31 -0500 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97B30C061573; Mon, 1 Feb 2021 17:52:51 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id b145so6489744pfb.4; Mon, 01 Feb 2021 17:52:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=4dPB0xdozLnJ4HtFbULqQeJT3HtsViC+HjWIT7oeuiI=; b=A596Ysvq014L9mFKZs37S5/W5bTE2ckwYfmpCpJ9nK27wUnTGUHfcS4olYHh1lwEYi OG/cmNrMZ26tasIl3Q05IDWl/L7kDiv6u0J6SksFwo9iFK2K6lc9PpwLmyCnDho+mehZ AYBbibs05MBm8Z6SI6sJrBe/I9tVoQnacJWdZH3O3fANifne1TFM/clp/0CFlVvuDBLz Qk2bF3qevUtqIag/7tnISR7FZ6TkzhH+oFCeAaL99nzf33V/4dcm6ET4hCE9epWFKHFh 5bHuvJwOh1oKv3pKEGkFwRwA4DJ9G+Rt3XsCWjTgn+a7fqsUHVabiv9qYDTlufjtZfmL 8IxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=4dPB0xdozLnJ4HtFbULqQeJT3HtsViC+HjWIT7oeuiI=; b=uR9fwtxKanOLzQ9oGClmWw9o6tsavsJXprn88LxkxNgcbX/x2lCz8XnLE8K0iZ5fGJ GcoL+gOzy9JkW3D2jPRlHLTA7JKTzd/+UihKtPFomaKKP6ZU3yRq3nxZxImKu3S3cR7f mW2kQ0siYOEvdJpc682MCfCvFnbXYLGnhx4k3lt0SkOeeKSC5or7CikNzKJCDGqUkhpS y2wJsY8I/Co2NpaQz2pBpsdG1cOznMfEclmQV+V8Sg459G2h4melV7hZTrszJIaW2OJG kzLP/P9mZ9nqlEteo+lMlMZ10E1DOluROoqkJNlaj3GsBuVol8BMy8r1wbV9VAyuMQDV dSZg== X-Gm-Message-State: AOAM533UMLGP7zlZObS/5DbWEheRLNBJdmxDVOkHv3R4Uy3mpLaEuPmL urVvz7VqmzUrSFU+m9mwV9w= X-Google-Smtp-Source: ABdhPJzpk7F4glgCPjEUcr5K297Ke5ORCshoB5cX9ev1Y19QQXM9NU6F/FQlje3ynVyzVGfMyxYuvg== X-Received: by 2002:a63:a542:: with SMTP id r2mr19669741pgu.211.1612230771093; Mon, 01 Feb 2021 17:52:51 -0800 (PST) Received: from localhost ([103.220.76.197]) by smtp.gmail.com with ESMTPSA id fs14sm712574pjb.46.2021.02.01.17.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 17:52:50 -0800 (PST) Date: Tue, 2 Feb 2021 09:52:34 +0800 From: Carlis To: Andy Shevchenko Cc: Greg Kroah-Hartman , Colin King , oliver.graute@kococonnector.com, zhangxuezhi1@yulong.com, Deepak R Varma , Stefano Brivio , dri-devel , "open list:FRAMEBUFFER LAYER" , "open list:STAGING SUBSYSTEM" , Linux Kernel Mailing List Subject: Re: [PATCH v12] staging: fbtft: add tearing signal detect Message-ID: <20210202095234.000059ca@gmail.com> In-Reply-To: References: <1611838435-151774-1-git-send-email-zhangxuezhi3@gmail.com> <20210129130110.00003bb1@gmail.com> <20210129215638.000047b0@gmail.com> <20210130143924.00005432@gmail.com> Organization: Coolpad X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Feb 2021 19:40:21 +0200 Andy Shevchenko wrote: > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote: > > On Fri, 29 Jan 2021 16:26:12 +0200 > > Andy Shevchenko wrote: > > > On Fri, Jan 29, 2021 at 3:56 PM carlis > > > wrote: > > > > On Fri, 29 Jan 2021 12:23:08 +0200 > > > > Andy Shevchenko wrote: > > ... > > > > > Hi, I apologize for what I said in the previous two emails. I > > > > missed one email you sent before, and now I probably understand > > > > what you meant. Here is a version I modified according to your > > > > suggestion: > > I have realized that you are mocking stuff in the generic fbtft > structure for all drivers while only a single one is going to use > that. Consider moving everything to the driver in question. > > hi, Do you mean that i define the TE completion and irq_te in the fb_st7789v.c as i did before?