From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9876C433E0 for ; Wed, 3 Feb 2021 11:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F74564F61 for ; Wed, 3 Feb 2021 11:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234103AbhBCLQd (ORCPT ); Wed, 3 Feb 2021 06:16:33 -0500 Received: from verein.lst.de ([213.95.11.211]:50646 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234046AbhBCLQb (ORCPT ); Wed, 3 Feb 2021 06:16:31 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id ACA1067357; Wed, 3 Feb 2021 12:15:48 +0100 (CET) Date: Wed, 3 Feb 2021 12:15:48 +0100 From: Christoph Hellwig To: Filippo Sironi Cc: Christoph Hellwig , serebrin@amazon.com, dwmw@amazon.co.uk, kbusch@kernel.org, axboe@fb.com, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk Message-ID: <20210203111548.GA11075@lst.de> References: <20210203094338.19473-1-sironi@amazon.de> <20210203095148.GA8897@lst.de> <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2021 at 12:12:31PM +0100, Filippo Sironi wrote: > I don't disagree on the first part of your sentence, this is a big > oversight. But it is not what your commit log suggests. > On the other hand, those controllers are out there and are in use by a lot > of customers. We can keep relying on luck, hoping that customers don't run > into troubles or we can merge a few lines of code :) Your patch does not just quirk a few controllers out there, but all current and future controllers with an Amazon vendor ID. We could probably talk about quirking an existing vendor ID or two as long as this doesn't happen for future hardware.